michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kconfig: Remove redundant $ZEPHYR_BASE from 'source's

Browse source 
The $srctree environment variable is already set to point to the Zephyr
root, so no need to do

    source "$(ZEPHYR_BASE)/Kconfig.zephyr"

in samples. Just

    source "Kconfig.zephyr"

works.

(Things would break if $srctree was set to anything else, because every
'source' in the Kconfig files will be relative to it.)

Also add a 'mainmenu' title to the littlefs sample. It shows up at the
top of menuconfig/guiconfig. Source Kconfig.zephyr instead of Kconfig to
avoid overriding it.

As a sidenote, $(FOO) is better $FOO in Kconfig. $FOO is legacy syntax
that Kconfiglib only supports to be compatible with old Linux kernels.
$(FOO) uses the Kconfig preprocessor.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2020-01-02 23:51:00 +01:00 • committed by Anas Nashif
commit 7e0af9e0b8
3 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
samples/net/updatehub/Kconfig
View file

@ -20,4 +20,4 @@ config UPDATEHUB_POLLING
intervention. intervention.
endif #!UPDATEHUB_MANUAL endif #!UPDATEHUB_MANUAL
source "$ZEPHYR_BASE/Kconfig.zephyr" source "Kconfig.zephyr"

4
samples/subsys/fs/littlefs/Kconfig
View file

@ -1,9 +1,11 @@
# Copyright (c) 2019 Peter Bigot Consulting, LLC # Copyright (c) 2019 Peter Bigot Consulting, LLC
# SPDX-License-Identifier: Apache-2.0 # SPDX-License-Identifier: Apache-2.0
mainmenu "littlefs sample"
config APP_WIPE_STORAGE config APP_WIPE_STORAGE
bool "Option to clear the flash area before mounting" bool "Option to clear the flash area before mounting"
help help
Use this to force an existing file system to be created. Use this to force an existing file system to be created.
source "$ZEPHYR_BASE/Kconfig" source "Kconfig.zephyr"

2
tests/kernel/profiling/profiling_api/Kconfig
View file

@ -10,4 +10,4 @@ config KERNEL_PROFILING_API_TEST
test to profile idle thread will be executed. test to profile idle thread will be executed.
# Include Zephyr's Kconfig. # Include Zephyr's Kconfig.
source "$ZEPHYR_BASE/Kconfig" source "Kconfig"