michaelh/zephyr
1
0
Fork 0
Code Releases Activity

pm: Remove unused parameter

Browse source 
The number of ticks on z_pm_save_idle_exit is not used and there is
no need to have it.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
This commit is contained in:
Flavio Ceolin 2021-11-15 21:22:38 -08:00 • committed by Christopher Friedt
commit 7dd4297214
7 changed files with 5 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

2
arch/arc/core/isr_wrapper.S
View file

@ -249,8 +249,6 @@ rirq_path:
#if defined(CONFIG_PM) #if defined(CONFIG_PM)
clri r0 /* do not interrupt exiting tickless idle operations */ clri r0 /* do not interrupt exiting tickless idle operations */
MOVR r1, _kernel MOVR r1, _kernel
/* z_kernel.idle is 32 bit despite of platform bittnes */
ld_s r3, [r1, _kernel_offset_to_idle] /* requested idle duration */
breq r3, 0, _skip_pm_save_idle_exit breq r3, 0, _skip_pm_save_idle_exit
st 0, [r1, _kernel_offset_to_idle] /* zero idle duration */ st 0, [r1, _kernel_offset_to_idle] /* zero idle duration */

4
arch/arm/core/aarch32/irq_manage.c
View file

@ -181,10 +181,8 @@ void _arch_isr_direct_pm(void)
#endif /* CONFIG_ARMV6_M_ARMV8_M_BASELINE */ #endif /* CONFIG_ARMV6_M_ARMV8_M_BASELINE */
if (_kernel.idle) { if (_kernel.idle) {
int32_t idle_val = _kernel.idle;
_kernel.idle = 0; _kernel.idle = 0;
z_pm_save_idle_exit(idle_val); z_pm_save_idle_exit();
} }
#if defined(CONFIG_ARMV6_M_ARMV8_M_BASELINE) \ #if defined(CONFIG_ARMV6_M_ARMV8_M_BASELINE) \

4
arch/posix/core/swap.c
View file

@ -111,10 +111,8 @@ void arch_switch_to_main_thread(struct k_thread *main_thread, char *stack_ptr,
void posix_irq_check_idle_exit(void) void posix_irq_check_idle_exit(void)
{ {
if (_kernel.idle) { if (_kernel.idle) {
int32_t idle_val = _kernel.idle;
_kernel.idle = 0; _kernel.idle = 0;
z_pm_save_idle_exit(idle_val); z_pm_save_idle_exit();
} }
} }
#endif #endif

4
arch/x86/core/ia32/intstub.S
View file

@ -301,8 +301,6 @@ nestedInterrupt:
handle_idle: handle_idle:
pushl %eax pushl %eax
pushl %edx pushl %edx
/* Populate 'ticks' argument to z_pm_save_idle_exit */
push _kernel_offset_to_idle(%ecx)
/* Zero out _kernel.idle */ /* Zero out _kernel.idle */
movl $0, _kernel_offset_to_idle(%ecx) movl $0, _kernel_offset_to_idle(%ecx)
@ -314,8 +312,6 @@ handle_idle:
*/ */
call z_pm_save_idle_exit call z_pm_save_idle_exit
/* discard 'ticks' argument passed on the stack */
add $0x4, %esp
popl %edx popl %edx
popl %eax popl %eax
jmp alreadyOnIntStack jmp alreadyOnIntStack

4
include/arch/x86/ia32/arch.h
View file

@ -244,10 +244,8 @@ typedef struct s_isrList {
static inline void arch_irq_direct_pm(void) static inline void arch_irq_direct_pm(void)
{ {
if (_kernel.idle) { if (_kernel.idle) {
int32_t idle_val = _kernel.idle;
_kernel.idle = 0; _kernel.idle = 0;
z_pm_save_idle_exit(idle_val); z_pm_save_idle_exit();
} }
} }

2
include/pm/pm.h
View file

@ -215,7 +215,7 @@ void pm_power_state_exit_post_ops(struct pm_state_info info);
#endif /* CONFIG_PM */ #endif /* CONFIG_PM */
void z_pm_save_idle_exit(int32_t ticks); void z_pm_save_idle_exit(void);
#ifdef __cplusplus #ifdef __cplusplus
} }

2
kernel/idle.c
View file

@ -48,7 +48,7 @@ static void pm_save_idle(void)
#endif #endif
} }
void z_pm_save_idle_exit(int32_t ticks) void z_pm_save_idle_exit(void)
{ {
#ifdef CONFIG_PM #ifdef CONFIG_PM
/* Some CPU low power states require notification at the ISR /* Some CPU low power states require notification at the ISR