michaelh/zephyr
1
0
Fork 0
Code Releases Activity

pm: use actions for device PM control

Browse source 
Instead of passing target states, use actions for device PM control.
Actions represent better the meaning of the callback argument.
Furthermore, they are more future proof as they can be suitable for
other PM actions that have no direct mapping to a state. If we compare
with Linux, we could have a multi-stage suspend/resume. Such scenario
would not have a good mapping when using target states.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
This commit is contained in:
Gerard Marull-Paretas 2021-07-05 15:13:40 +02:00 • committed by Anas Nashif
commit 7ccc1a41bc
40 changed files with 176 additions and 145 deletions
Download patch file Download diff file Expand all files Collapse all files

8
drivers/i2c/i2c_nrfx_twim.c
View file

@ -255,12 +255,12 @@ static int init_twim(const struct device *dev)
#ifdef CONFIG_PM_DEVICE
static int twim_nrfx_pm_control(const struct device *dev,
enum pm_device_state state)
enum pm_device_action action)
{
int ret = 0;
switch (state) {
case PM_DEVICE_STATE_ACTIVE:
switch (action) {
case PM_DEVICE_ACTION_RESUME:
init_twim(dev);
if (get_dev_data(dev)->dev_config) {
i2c_nrfx_twim_configure(dev,
@ -268,7 +268,7 @@ static int twim_nrfx_pm_control(const struct device *dev,
}
break;
case PM_DEVICE_STATE_SUSPENDED:
case PM_DEVICE_ACTION_SUSPEND:
nrfx_twim_uninit(&get_dev_config(dev)->twim);
break;