michaelh/zephyr
1
0
Fork 0
Code Releases Activity

include: debug: remove old stack functions

Browse source 
These were unsafe.

Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
This commit is contained in:
Andrew Boie 2020-03-12 15:03:52 -07:00 • committed by Anas Nashif
commit 7cb8f5c61e
1 changed files with 0 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

75
include/debug/stack.h
View file

@ -15,81 +15,6 @@
#include <logging/log.h>
#include <stdbool.h>
static inline size_t stack_unused_space_get(const char *stack, size_t size)
{
size_t unused = 0;
if (IS_ENABLED(CONFIG_INIT_STACKS)) {
const unsigned char *checked_stack =
(const unsigned char *)stack;
if (IS_ENABLED(CONFIG_STACK_SENTINEL)) {
/* First 4 bytes of the stack buffer reserved for the
* sentinel value, it won't be 0xAAAAAAAA for thread
* stacks.
*/
checked_stack += 4;
}
/* TODO Currently all supported platforms have stack growth down
* and there is no Kconfig option to configure it so this always
* build "else" branch.
* When support for platform with stack direction up
* (or configurable direction) is added this check should be
* confirmed that correct Kconfig option is used.
*/
if (IS_ENABLED(CONFIG_STACK_GROWS_UP)) {
for (size_t i = size; i > 0; i--) {
if (checked_stack[i - 1] == 0xaaU) {
unused++;
} else {
break;
}
}
} else {
for (size_t i = 0; i < size; i++) {
if (checked_stack[i] == 0xaaU) {
unused++;
} else {
break;
}
}
}
}
return unused;
}
__deprecated
static inline void stack_analyze(const char *name, const char *stack,
unsigned int size)
{
if (IS_ENABLED(CONFIG_INIT_STACKS)) {
LOG_MODULE_DECLARE(os, CONFIG_KERNEL_LOG_LEVEL);
unsigned int unused = stack_unused_space_get(stack, size);
unsigned int pcnt = ((size - unused) * 100U) / size;
LOG_INF("%s :\tunused %u\tusage %u / %u (%u %%)",
name, unused, size - unused, size, pcnt);
}
}
/**
* @brief Analyze stacks.
*
* Use this macro to get information about stack usage.
*
* @param name Name of the stack
* @param sym The symbol of the stack
*/
#define STACK_ANALYZE(name, sym) DEPRECATED_MACRO \
do { \
stack_analyze(name, \
Z_THREAD_STACK_BUFFER(sym), \
K_THREAD_STACK_SIZEOF(sym)); \
} while (false)
static inline void log_stack_usage(const struct k_thread *thread)
{
#if defined(CONFIG_INIT_STACKS) && defined(CONFIG_THREAD_STACK_INFO)