michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers/spi: dw: Fix unaligned access

Browse source 
The buffers aren't guaranteed to be aligned so that they're always
aligned for uint16_t or uint32_t data. Use the available unaligned
access macros to read/write the data.

Change-Id: Ie87c108aa370af196b9c759b59ed7fb9d1ed6183
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
This commit is contained in:
Johan Hedberg 2016-03-04 12:54:09 +02:00 • committed by Gerrit Code Review
commit 7c5563fd3a
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
drivers/spi/spi_dw.c
View file

@ -103,14 +103,14 @@ static void push_data(struct device *dev)
if (spi->tx_buf && spi->tx_buf_len > 0) {
switch (spi->dfs) {
case 1:
data = *(uint8_t *)(spi->tx_buf);
data = UNALIGNED_GET((uint8_t *)(spi->tx_buf));
break;
case 2:
data = *(uint16_t *)(spi->tx_buf);
data = UNALIGNED_GET((uint16_t *)(spi->tx_buf));
break;
#ifndef CONFIG_ARC
case 4:
data = *(uint32_t *)(spi->tx_buf);
data = UNALIGNED_GET((uint32_t *)(spi->tx_buf));
break;
#endif
}
@ -156,14 +156,14 @@ static void pull_data(struct device *dev)
if (spi->rx_buf && spi->rx_buf_len > 0) {
switch (spi->dfs) {
case 1:
*(uint8_t *)(spi->rx_buf) = (uint8_t)data;
UNALIGNED_PUT(data, (uint8_t *)spi->rx_buf);
break;
case 2:
*(uint16_t *)(spi->rx_buf) = (uint16_t)data;
UNALIGNED_PUT(data, (uint16_t *)spi->rx_buf);
break;
#ifndef CONFIG_ARC
case 4:
*(uint32_t *)(spi->rx_buf) = (uint32_t)data;
UNALIGNED_PUT(data, (uint32_t *)spi->rx_buf);
break;
#endif
}