michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: gsm_ppp: Wait for NET_IF_DOWN in gsm_ppp_stop only if iface was up

Browse source 
Check if ppp iface was actually up before taking it down and waiting
for NET_EVENT_IF_DOWN. This allows to call gsm_ppp_stop() even if
the PPP was never started, which previously caused the call to lock
forever. This case is useful, for example, if the modem didn't attach
to network in desirable time and user wants to abort PPP setup.

Signed-off-by: Marek Metelski <marek@metelski.dev>
This commit is contained in:
Marek Metelski 2022-06-07 11:42:54 +02:00 • committed by Carles Cufí
commit 7ade471a47
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
drivers/modem/gsm_ppp.c
View file

@ -1154,11 +1154,11 @@ void gsm_ppp_stop(const struct device *dev)
gsm_ppp_lock(gsm);
net_if_l2(iface)->enable(iface, false);
/* wait for the interface to be properly down */
(void)k_sem_take(&gsm->sem_if_down, K_FOREVER);
if (net_if_is_up(iface)) {
net_if_l2(iface)->enable(iface, false);
(void)k_sem_take(&gsm->sem_if_down, K_FOREVER);
}
if (IS_ENABLED(CONFIG_GSM_MUX)) {
if (gsm->ppp_dev) {