michaelh/zephyr
1
0
Fork 0
Code Releases Activity

x86: define dynamic thread object alignment

Browse source 
x86 and x86_64 require certain alignment in the k_thread struct
since the buffer to save/restore FPU/SSE registers requires
strict alignment.

Fixes #29589
Fixes #29629

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This commit is contained in:
Daniel Leung 2020-12-16 19:22:50 -08:00 • committed by Andrew Boie
commit 7a5f9e81de
2 changed files with 24 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

19
include/arch/x86/ia32/arch.h
View file

@ -445,6 +445,25 @@ extern struct task_state_segment _main_tss;
CODE_UNREACHABLE; \
} while (false)
/*
* Dynamic thread object memory alignment.
*
* If support for SSEx extensions is enabled a 16 byte boundary is required,
* since the 'fxsave' and 'fxrstor' instructions require this. In all other
* cases a 4 byte boundary is sufficient.
*/
#if defined(CONFIG_EAGER_FPU_SHARING) || defined(CONFIG_LAZY_FPU_SHARING)
#ifdef CONFIG_SSE
#define ARCH_DYMANIC_OBJ_K_THREAD_ALIGNMENT 16
#else
#define ARCH_DYMANIC_OBJ_K_THREAD_ALIGNMENT (sizeof(void *))
#endif
#else
/* No special alignment requirements, simply align on pointer size. */
#define ARCH_DYMANIC_OBJ_K_THREAD_ALIGNMENT (sizeof(void *))
#endif /* CONFIG_*_FP_SHARING */
#ifdef __cplusplus
}
#endif

5
include/arch/x86/intel64/arch.h
View file

@ -133,4 +133,9 @@ struct x86_ssf {
(void (*)(const void *))isr_p, \
isr_param_p, flags_p)
/*
* Thread object needs to be 16-byte aligned.
*/
#define ARCH_DYMANIC_OBJ_K_THREAD_ALIGNMENT 16
#endif /* ZEPHYR_INCLUDE_ARCH_X86_INTEL64_ARCH_H_ */