michaelh/zephyr
1
0
Fork 0
Code Releases Activity

arch/xtensa: Make cache utilities ALWAYS_INLINE

Browse source 
These are tiny functions always declared as "inline" per C99, but
that's just a hint.  In practice, they tend to be (c.f. intel_asdp)
called from very early boot circumstances where main application
symbols aren't yet available.  That obviously doesn't work, or even
link.

Make them ALWAYS_INLINE.  In practice they're so small that we don't
want them called anyway just for stack space reasons.

Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
This commit is contained in:
Andy Ross 2021-12-10 15:37:31 -08:00 • committed by Maureen Helm
commit 79746d701b
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
include/arch/xtensa/cache.h
View file

@ -20,7 +20,7 @@ BUILD_ASSERT(Z_IS_POW2(XCHAL_DCACHE_LINESIZE));
BUILD_ASSERT(Z_IS_POW2(Z_DCACHE_MAX));
#endif
static inline void z_xtensa_cache_flush(void *addr, size_t bytes)
static ALWAYS_INLINE void z_xtensa_cache_flush(void *addr, size_t bytes)
{
#if XCHAL_DCACHE_SIZE
size_t step = XCHAL_DCACHE_LINESIZE;
@ -34,7 +34,7 @@ static inline void z_xtensa_cache_flush(void *addr, size_t bytes)
#endif
}
static inline void z_xtensa_cache_flush_inv(void *addr, size_t bytes)
static ALWAYS_INLINE void z_xtensa_cache_flush_inv(void *addr, size_t bytes)
{
#if XCHAL_DCACHE_SIZE
size_t step = XCHAL_DCACHE_LINESIZE;
@ -48,7 +48,7 @@ static inline void z_xtensa_cache_flush_inv(void *addr, size_t bytes)
#endif
}
static inline void z_xtensa_cache_inv(void *addr, size_t bytes)
static ALWAYS_INLINE void z_xtensa_cache_inv(void *addr, size_t bytes)
{
#if XCHAL_DCACHE_SIZE
size_t step = XCHAL_DCACHE_LINESIZE;
@ -62,17 +62,17 @@ static inline void z_xtensa_cache_inv(void *addr, size_t bytes)
#endif
}
static inline void z_xtensa_cache_inv_all(void)
static ALWAYS_INLINE void z_xtensa_cache_inv_all(void)
{
z_xtensa_cache_inv(NULL, Z_DCACHE_MAX);
}
static inline void z_xtensa_cache_flush_all(void)
static ALWAYS_INLINE void z_xtensa_cache_flush_all(void)
{
z_xtensa_cache_flush(NULL, Z_DCACHE_MAX);
}
static inline void z_xtensa_cache_flush_inv_all(void)
static ALWAYS_INLINE void z_xtensa_cache_flush_inv_all(void)
{
z_xtensa_cache_flush_inv(NULL, Z_DCACHE_MAX);
}