michaelh/zephyr
1
0
Fork 0
Code Releases Activity

gpio_smartbond: Fix port_set_masked_raw

Browse source 
Writing directly to Px_DATA_REG modifies pins which are not
indicated by mask, causing gpio_basic_api test to fail.

Use Px_SET_DATA_REG and Px_RESET_DATA_REG to modify only
pins indicated by mask.

Signed-off-by: Ioannis Damigos <ioannis.damigos.uj@renesas.com>
This commit is contained in:
Ioannis Damigos 2024-07-29 16:20:06 +03:00 • committed by Anas Nashif
commit 782967a1e3
2 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
drivers/gpio/gpio_smartbond.c
View file

@ -164,7 +164,8 @@ static int gpio_smartbond_port_set_masked_raw(const struct device *dev,
{ {
const struct gpio_smartbond_config *config = dev->config; const struct gpio_smartbond_config *config = dev->config;
config->data_regs->data = value & mask; config->data_regs->set = value & mask;
config->data_regs->reset = ~value & mask;
return 0; return 0;
} }

13
tests/drivers/gpio/gpio_basic_api/boards/da1469x_dk_pro.overlay Normal file
View file

@ -0,0 +1,13 @@
/*
* Copyright (c) 2024 Renesas Electronics Corporation
*
* SPDX-License-Identifier: Apache-2.0
*/
/ {
resources {
compatible = "test-gpio-basic-api";
out-gpios = <&gpio0 2 0>;
in-gpios = <&gpio0 3 0>;
};
};