michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: Controller: fix wrong use of LE Features in CTE REQ llcp

Browse source 
When Host calls HCI_LE_Connection_CTE_Request_Enable with cte type
set to AoD with 1us slots or AoD with  2 us slots, the Controller
verifies if peer device supports Antenna Switching During CTE
Transmission (AoD) feature.

That is wrong because the feature is marked as optional when send
to peer, so it shall be igonerd by remote device.

There are no means to check if peer device supports particular
CTE type, hence the check has to be removed.

The check causes enable CTE REQ procedure to fail after feature
exchange has happened.

Signed-off-by: Piotr Pryga <piotr.pryga@nordicsemi.no>
This commit is contained in:
Piotr Pryga 2022-04-06 13:31:20 +02:00 • committed by Carles Cufí
commit 77ae58ee72
1 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
subsys/bluetooth/controller/ll_sw/ull_df.c
View file

@ -1213,11 +1213,7 @@ uint8_t ll_df_set_conn_cte_req_enable(uint16_t handle, uint8_t enable,
* whether required features are enabled. * whether required features are enabled.
*/ */
if (conn->llcp.fex.valid && if (conn->llcp.fex.valid &&
(!(conn->llcp.fex.features_peer & BIT64(BT_LE_FEAT_BIT_CONN_CTE_RESP)) || (!(conn->llcp.fex.features_peer & BIT64(BT_LE_FEAT_BIT_CONN_CTE_RESP)))) {
((requested_cte_type == BT_HCI_LE_AOD_CTE_1US ||
requested_cte_type == BT_HCI_LE_AOD_CTE_2US) &&
!(conn->llcp.fex.features_peer &
BIT64(BT_LE_FEAT_BIT_ANT_SWITCH_TX_AOD))))) {
return BT_HCI_ERR_UNSUPP_REMOTE_FEATURE; return BT_HCI_ERR_UNSUPP_REMOTE_FEATURE;
} }