michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: Shell: Fix off-by-one in address length validation

Browse source 
Fixes Coverity defect id 248346.

Signed-off-by: Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no>
This commit is contained in:
Aleksander Wasaznik 2022-04-22 12:43:23 +02:00 • committed by Carles Cufí
commit 77ad017672
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
subsys/bluetooth/shell/bt.c
View file

@ -1048,8 +1048,8 @@ static int cmd_scan_filter_set_addr(const struct shell *sh, size_t argc,
{
const char *addr_arg = argv[1];
/* Validate length */
if (strlen(addr_arg) > sizeof(scan_filter.addr)) {
/* Validate length including null terminator. */
if (strlen(addr_arg) >= sizeof(scan_filter.addr)) {
shell_error(ctx_shell, "Invalid address string: %s\n",
addr_arg);
return -ENOEXEC;