michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: clock_control_nrf: Prevent break from becoming dead code

Browse source 
When both NRF_CLOCK_HAS_XO_TUNE and NRF_CLOCK_HAS_PLL evaluate to 0,
one break statement can end up not associated with any case and become
dead code. Refactor a bit the related switch to avoid such situation.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
This commit is contained in:
Andrzej Głąbek 2025-05-26 12:59:11 +02:00 • committed by Benjamin Cabé
commit 77a7cb3e4f
1 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
drivers/clock_control/clock_control_nrf.c
View file

@ -692,6 +692,10 @@ static void clock_event_handler(nrfx_clock_evt_type_t event)
case NRFX_CLOCK_EVT_XO_TUNED: case NRFX_CLOCK_EVT_XO_TUNED:
clkstarted_handle(dev, CLOCK_CONTROL_NRF_TYPE_HFCLK); clkstarted_handle(dev, CLOCK_CONTROL_NRF_TYPE_HFCLK);
break; break;
case NRFX_CLOCK_EVT_XO_TUNE_ERROR:
case NRFX_CLOCK_EVT_XO_TUNE_FAILED:
/* No processing needed. */
break;
case NRFX_CLOCK_EVT_HFCLK_STARTED: case NRFX_CLOCK_EVT_HFCLK_STARTED:
/* HFCLK is stable after XOTUNED event. /* HFCLK is stable after XOTUNED event.
* HFCLK_STARTED means only that clock has been started. * HFCLK_STARTED means only that clock has been started.
@ -743,15 +747,9 @@ static void clock_event_handler(nrfx_clock_evt_type_t event)
#endif #endif
#if NRF_CLOCK_HAS_PLL #if NRF_CLOCK_HAS_PLL
case NRFX_CLOCK_EVT_PLL_STARTED: case NRFX_CLOCK_EVT_PLL_STARTED:
#endif /* No processing needed. */
#if NRF_CLOCK_HAS_XO_TUNE
case NRFX_CLOCK_EVT_XO_TUNE_ERROR:
case NRFX_CLOCK_EVT_XO_TUNE_FAILED:
#endif
{
/* unhandled event */
break; break;
} #endif
default: default:
__ASSERT_NO_MSG(0); __ASSERT_NO_MSG(0);
break; break;