michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: drivers: spi: spi_slave: Fix memory corruption

Browse source 
This fixes memory corruption of delayable work when
tests executes unsupported function.

When test (e.g. only_rx_in_chunks) is executed it starts
delayed work for master functionality (with 10 ms delay).
Later when slave function is tried and reports that
function is unsupported, test is terminated (task ends)
but work is still scheduled.

When next test starts it clears work that is already
scheduled:

static void before(void *not_used)
{
	ARG_UNUSED(not_used);

	memset(&tdata, 0, sizeof(tdata));

this leads to memory corruption and system work queue
tries to remove work but it never does since head/next
pointers are zeroed at that time.

This just adds after function that cancels work
regardless if it was scheduled or not.

Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
This commit is contained in:
Jerzy Kasenberg 2024-10-15 12:38:11 +02:00 • committed by Benjamin Cabé
commit 75d3f45d5a
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/drivers/spi/spi_controller_peripheral/src/main.c
View file

@ -530,9 +530,16 @@ static void before(void *not_used)
k_sem_init(&tdata.sem, 0, 1);
}
static void after(void *not_used)
{
ARG_UNUSED(not_used);
k_work_cancel_delayable(&tdata.test_work);
}
static void *suite_setup(void)
{
return NULL;
}
ZTEST_SUITE(spi_controller_peripheral, NULL, suite_setup, before, NULL, NULL);
ZTEST_SUITE(spi_controller_peripheral, NULL, suite_setup, before, after, NULL);