From 754174200217944e418c5f98cde58ec433da4f5d Mon Sep 17 00:00:00 2001 From: Tomas Choat Date: Tue, 26 Nov 2024 10:51:50 +0100 Subject: [PATCH] net: lib: ptp: Assert statements inverted The asserts always fail because the condition is inverted. This patch fixes the condition to verify the socket is lower than PTP_SOCKET_CNT. Signed-off-by: Tomas Choat --- subsys/net/lib/ptp/transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/subsys/net/lib/ptp/transport.c b/subsys/net/lib/ptp/transport.c index 3543a1faf32..3494fefa065 100644 --- a/subsys/net/lib/ptp/transport.c +++ b/subsys/net/lib/ptp/transport.c @@ -266,7 +266,7 @@ int ptp_transport_close(struct ptp_port *port) int ptp_transport_send(struct ptp_port *port, struct ptp_msg *msg, enum ptp_socket idx) { - __ASSERT(PTP_SOCKET_CNT <= idx, "Invalid socket index"); + __ASSERT(PTP_SOCKET_CNT > idx, "Invalid socket index"); static const int socket_port[] = {PTP_SOCKET_PORT_EVENT, PTP_SOCKET_PORT_GENERAL}; int length = ntohs(msg->header.msg_length); @@ -276,7 +276,7 @@ int ptp_transport_send(struct ptp_port *port, struct ptp_msg *msg, enum ptp_sock int ptp_transport_sendto(struct ptp_port *port, struct ptp_msg *msg, enum ptp_socket idx) { - __ASSERT(PTP_SOCKET_CNT <= idx, "Invalid socket index"); + __ASSERT(PTP_SOCKET_CNT > idx, "Invalid socket index"); static const int socket_port[] = {PTP_SOCKET_PORT_EVENT, PTP_SOCKET_PORT_GENERAL}; int length = ntohs(msg->header.msg_length); @@ -286,7 +286,7 @@ int ptp_transport_sendto(struct ptp_port *port, struct ptp_msg *msg, enum ptp_so int ptp_transport_recv(struct ptp_port *port, struct ptp_msg *msg, enum ptp_socket idx) { - __ASSERT(PTP_SOCKET_CNT <= idx, "Invalid socket index"); + __ASSERT(PTP_SOCKET_CNT > idx, "Invalid socket index"); int cnt = 0; uint8_t ctrl[CMSG_SPACE(sizeof(struct net_ptp_time))] = {0};