From 751ee21e08037112c3ee5999a8532e3c0709723d Mon Sep 17 00:00:00 2001 From: Ulf Magnusson Date: Tue, 3 Sep 2019 14:13:15 +0200 Subject: [PATCH] doc: application.py: Simplify test with 'in' Getting slightly subjective, but fixes this pylint warning: doc/extensions/zephyr/application.py:274:15: R1714: Consider merging these comparisons with "in" to "goal in ('build', 'sign')" (consider-using-in) Use a set literal instead of a tuple literal, as recent Python 3 versions optimize set literals with constant keys nicely. Getting rid of pylint warnings for a CI check. I could disable any controversial ones (it's already a list of warnings to enable anyway). Signed-off-by: Ulf Magnusson --- doc/extensions/zephyr/application.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/extensions/zephyr/application.py b/doc/extensions/zephyr/application.py index d532e47408b..6926b6b2460 100644 --- a/doc/extensions/zephyr/application.py +++ b/doc/extensions/zephyr/application.py @@ -270,7 +270,7 @@ class ZephyrAppCommandsDirective(Directive): content.append('west sign{}'.format(dst)) for goal in goals: - if goal == 'build' or goal == 'sign': + if goal in {'build', 'sign'}: continue elif goal == 'flash': content.append('west flash{}'.format(dst))