michaelh/zephyr
1
0
Fork 0
Code Releases Activity

arch/common: Provide a weak, generic z_arch_irq_connect_dynamic()

Browse source 
It was discovered that the xtensa version of
z_arch_irq_connect_dynamic() was being removed along with the old
xtensa architecture support, because it was never included in the asm2
builds.

But there's no xtensa-specific code in it at all.  Architectures that
use the existing sw_isr_table mechanism and don't (or can't, in the
case of xtensa which has fixed interrupt priority) interpret the other
parameters might as well have access to a working generic
implementation.

Fixes #18272

Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
This commit is contained in:
Andy Ross 2019-08-20 11:44:48 -07:00 • committed by Anas Nashif
commit 74d26094f8
1 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

17
arch/common/sw_isr_common.c
View file

@ -24,4 +24,21 @@ void z_isr_install(unsigned int irq, void (*routine)(void *), void *param)
_sw_isr_table[table_idx].arg = param; _sw_isr_table[table_idx].arg = param;
_sw_isr_table[table_idx].isr = routine; _sw_isr_table[table_idx].isr = routine;
} }
/* Some architectures don't/can't interpret flags or priority and have
* no more processing to do than this. Provide a generic fallback.
*/
int __weak z_arch_irq_connect_dynamic(unsigned int irq,
unsigned int priority,
void (*routine)(void *),
void *parameter,
u32_t flags)
{
ARG_UNUSED(flags);
ARG_UNUSED(priority);
z_isr_install(irq, routine, parameter);
return irq;
}
#endif /* CONFIG_DYNAMIC_INTERRUPTS */ #endif /* CONFIG_DYNAMIC_INTERRUPTS */