michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: uart_imx: Fix the poll_in function

Browse source 
Current poll_in function implementation blocks when there is
no data available. The Zephyr documentation for poll_in
expects the function to return -1 when no data is available.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
This commit is contained in:
Mahesh Mahadevan 2022-05-20 16:41:46 -05:00 • committed by David Leach
commit 70dbf7e695
1 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
drivers/serial/uart_imx.c
View file

@ -113,16 +113,18 @@ static void uart_imx_poll_out(const struct device *dev, unsigned char c)
static int uart_imx_poll_in(const struct device *dev, unsigned char *c) static int uart_imx_poll_in(const struct device *dev, unsigned char *c)
{ {
UART_Type *uart = UART_STRUCT(dev); UART_Type *uart = UART_STRUCT(dev);
int ret = -1;
while (!UART_GetStatusFlag(uart, uartStatusRxDataReady)) { if (UART_GetStatusFlag(uart, uartStatusRxDataReady)) {
} *c = UART_Getchar(uart);
*c = UART_Getchar(uart);
if (UART_GetStatusFlag(uart, uartStatusRxOverrun)) { if (UART_GetStatusFlag(uart, uartStatusRxOverrun)) {
UART_ClearStatusFlag(uart, uartStatusRxOverrun); UART_ClearStatusFlag(uart, uartStatusRxOverrun);
}
ret = 0;
} }
return 0; return ret;
} }
#ifdef CONFIG_UART_INTERRUPT_DRIVEN #ifdef CONFIG_UART_INTERRUPT_DRIVEN