michaelh/zephyr
1
0
Fork 0
Code Releases Activity

led: drop a bunch of on/off wrappers

Browse source 
These are now handled at API level, drop them from the drivers.

Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
This commit is contained in:
Fabio Baltieri 2025-05-09 10:14:45 +01:00 • committed by Benjamin Cabé
commit 6f47466899
9 changed files with 0 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

12
drivers/led/is31fl3194.c
View file

@ -166,16 +166,6 @@ static int is31fl3194_set_brightness(const struct device *dev, uint32_t led, uin
return ret;
}
static inline int is31fl3194_led_on(const struct device *dev, uint32_t led)
{
return is31fl3194_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}
static inline int is31fl3194_led_off(const struct device *dev, uint32_t led)
{
return is31fl3194_set_brightness(dev, led, 0);
}
/*
* Counts red, green, blue channels; returns true if color_id is valid
* and no more than one channel maps to the same color
@ -315,8 +305,6 @@ static int is31fl3194_init(const struct device *dev)
static DEVICE_API(led, is31fl3194_led_api) = {
.set_brightness = is31fl3194_set_brightness,
.on = is31fl3194_led_on,
.off = is31fl3194_led_off,
.get_info = is31fl3194_get_info,
.set_color = is31fl3194_set_color,
};

12
drivers/led/is31fl3216a.c
View file

@ -124,16 +124,6 @@ static int is31fl3216a_led_set_brightness(const struct device *dev,
return is31fl3216a_update_pwm(&config->i2c);
}
static int is31fl3216a_led_on(const struct device *dev, uint32_t led)
{
return is31fl3216a_led_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}
static int is31fl3216a_led_off(const struct device *dev, uint32_t led)
{
return is31fl3216a_led_set_brightness(dev, led, 0);
}
static int is31fl3216a_init_registers(const struct i2c_dt_spec *i2c)
{
int i;
@ -224,8 +214,6 @@ static int is31fl3216a_init(const struct device *dev)
static DEVICE_API(led, is31fl3216a_led_api) = {
.set_brightness = is31fl3216a_led_set_brightness,
.on = is31fl3216a_led_on,
.off = is31fl3216a_led_off,
.write_channels = is31fl3216a_led_write_channels
};

12
drivers/led/is31fl3733.c
View file

@ -111,16 +111,6 @@ static int is31fl3733_led_set_brightness(const struct device *dev, uint32_t led,
return i2c_reg_write_byte_dt(&config->bus, led, led_brightness);
}
static int is31fl3733_led_on(const struct device *dev, uint32_t led)
{
return is31fl3733_led_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}
static int is31fl3733_led_off(const struct device *dev, uint32_t led)
{
return is31fl3733_led_set_brightness(dev, led, 0);
}
static int is31fl3733_led_write_channels(const struct device *dev, uint32_t start_channel,
uint32_t num_channels, const uint8_t *buf)
{
@ -274,8 +264,6 @@ int is31fl3733_current_limit(const struct device *dev, uint8_t limit)
}
static DEVICE_API(led, is31fl3733_api) = {
.on = is31fl3733_led_on,
.off = is31fl3733_led_off,
.set_brightness = is31fl3733_led_set_brightness,
.write_channels = is31fl3733_led_write_channels,
};

24
drivers/led/led_dac.c
View file

@ -49,31 +49,7 @@ static int led_dac_set_brightness(const struct device *dev, uint32_t led, uint8_
return led_dac_set_raw(dev, led, value);
}
static inline int led_dac_on(const struct device *dev, uint32_t led)
{
const struct led_dac_config *config = dev->config;
if (led >= config->num_leds) {
return -EINVAL;
}
return led_dac_set_raw(dev, led, config->leds[led].dac_max_brightness);
}
static inline int led_dac_off(const struct device *dev, uint32_t led)
{
const struct led_dac_config *config = dev->config;
if (led >= config->num_leds) {
return -EINVAL;
}
return led_dac_set_raw(dev, led, 0);
}
static DEVICE_API(led, led_dac_api) = {
.on = led_dac_on,
.off = led_dac_off,
.set_brightness = led_dac_set_brightness,
};

12
drivers/led/led_gpio.c
View file

@ -39,16 +39,6 @@ static int led_gpio_set_brightness(const struct device *dev, uint32_t led, uint8
return gpio_pin_set_dt(led_gpio, value > 0);
}
static int led_gpio_on(const struct device *dev, uint32_t led)
{
return led_gpio_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}
static int led_gpio_off(const struct device *dev, uint32_t led)
{
return led_gpio_set_brightness(dev, led, 0);
}
static int led_gpio_init(const struct device *dev)
{
const struct led_gpio_config *config = dev->config;
@ -78,8 +68,6 @@ static int led_gpio_init(const struct device *dev)
}
static DEVICE_API(led, led_gpio_api) = {
.on = led_gpio_on,
.off = led_gpio_off,
.set_brightness = led_gpio_set_brightness,
};

12
drivers/led/led_pwm.c
View file

@ -68,16 +68,6 @@ static int led_pwm_set_brightness(const struct device *dev,
(uint32_t) ((uint64_t) dt_led->period * value / LED_BRIGTHNESS_MAX));
}
static int led_pwm_on(const struct device *dev, uint32_t led)
{
return led_pwm_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}
static int led_pwm_off(const struct device *dev, uint32_t led)
{
return led_pwm_set_brightness(dev, led, 0);
}
static int led_pwm_init(const struct device *dev)
{
const struct led_pwm_config *config = dev->config;
@ -125,8 +115,6 @@ static int led_pwm_pm_action(const struct device *dev,
#endif /* CONFIG_PM_DEVICE */
static DEVICE_API(led, led_pwm_api) = {
.on = led_pwm_on,
.off = led_pwm_off,
.blink = led_pwm_blink,
.set_brightness = led_pwm_set_brightness,
};

12
drivers/led/lp50xx.c
View file

@ -136,16 +136,6 @@ static int lp50xx_set_brightness(const struct device *dev,
return i2c_write_dt(&config->bus, buf, sizeof(buf));
}
static int lp50xx_on(const struct device *dev, uint32_t led)
{
return lp50xx_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}
static int lp50xx_off(const struct device *dev, uint32_t led)
{
return lp50xx_set_brightness(dev, led, 0);
}
static int lp50xx_set_color(const struct device *dev, uint32_t led,
uint8_t num_colors, const uint8_t *color)
{
@ -350,8 +340,6 @@ static int lp50xx_pm_action(const struct device *dev,
#endif /* CONFIG_PM_DEVICE */
static DEVICE_API(led, lp50xx_led_api) = {
.on = lp50xx_on,
.off = lp50xx_off,
.get_info = lp50xx_get_info,
.set_brightness = lp50xx_set_brightness,
.set_color = lp50xx_set_color,

14
drivers/led/lp5569.c
View file

@ -65,18 +65,6 @@ static int lp5569_led_set_brightness(const struct device *dev, uint32_t led, uin
return 0;
}
static inline int lp5569_led_on(const struct device *dev, uint32_t led)
{
/* Set LED brightness to 100 % */
return lp5569_led_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}
static inline int lp5569_led_off(const struct device *dev, uint32_t led)
{
/* Set LED brightness to 0 % */
return lp5569_led_set_brightness(dev, led, 0);
}
static int lp5569_write_channels(const struct device *dev, uint32_t start_channel,
uint32_t num_channels, const uint8_t *buf)
{
@ -185,8 +173,6 @@ static int lp5569_pm_action(const struct device *dev, enum pm_device_action acti
static DEVICE_API(led, lp5569_led_api) = {
.set_brightness = lp5569_led_set_brightness,
.on = lp5569_led_on,
.off = lp5569_led_off,
.write_channels = lp5569_write_channels,
};

12
drivers/led/ncp5623.c
View file

@ -120,16 +120,6 @@ static int ncp5623_set_brightness(const struct device *dev, uint32_t led, uint8_
return ret;
}
static inline int ncp5623_led_on(const struct device *dev, uint32_t led)
{
return ncp5623_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}
static inline int ncp5623_led_off(const struct device *dev, uint32_t led)
{
return ncp5623_set_brightness(dev, led, 0);
}
static int ncp5623_led_init(const struct device *dev)
{
const struct ncp5623_config *config = dev->config;
@ -186,8 +176,6 @@ static int ncp5623_led_init(const struct device *dev)
static DEVICE_API(led, ncp5623_led_api) = {
.set_brightness = ncp5623_set_brightness,
.on = ncp5623_led_on,
.off = ncp5623_led_off,
.get_info = ncp5623_get_info,
.set_color = ncp5623_set_color,
};