michaelh/zephyr
1
0
Fork 0
Code Releases Activity

pm: Move settting timeout to after suspending devices

Browse source 
pm_suspend_devices() could return an error. Set timeout using
sys_clock_set_timeout() to after this error is handled so that
we have the accurate power state when calling the timeout function.
This is useful in cases where we wish to compensate the
system timer for certain power modes.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
This commit is contained in:
Mahesh Mahadevan 2023-12-07 18:50:12 +00:00 • committed by Carles Cufí
commit 6cb1ff6560
1 changed files with 12 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

23
subsys/pm/pm.c
View file

@ -197,17 +197,6 @@ bool pm_system_suspend(int32_t ticks)
return false;
}
if (ticks != K_TICKS_FOREVER) {
/*
* We need to set the timer to interrupt a little bit early to
* accommodate the time required by the CPU to fully wake up.
*/
sys_clock_set_timeout(ticks -
k_us_to_ticks_ceil32(
z_cpus_pm_state[id].exit_latency_us),
true);
}
#if defined(CONFIG_PM_DEVICE) && !defined(CONFIG_PM_DEVICE_RUNTIME_EXCLUSIVE)
if (atomic_sub(&_cpus_active, 1) == 1) {
if (z_cpus_pm_state[id].state != PM_STATE_RUNTIME_IDLE) {
@ -222,6 +211,18 @@ bool pm_system_suspend(int32_t ticks)
}
}
#endif
if (ticks != K_TICKS_FOREVER) {
/*
* We need to set the timer to interrupt a little bit early to
* accommodate the time required by the CPU to fully wake up.
*/
sys_clock_set_timeout(ticks -
k_us_to_ticks_ceil32(
z_cpus_pm_state[id].exit_latency_us),
true);
}
/*
* This function runs with interruptions locked but it is
* expected the SoC to unlock them in