michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: BAP: Broadcast Source: Modify when enabling state is set

Browse source 
Modify when the BT_BAP_EP_STATE_ENABLING state is set during
bt_bap_broadcast_source_start.

The reason why the state is now set before the call to
bt_iso_big_create, is to handle the case where the BIG
created event actually happens and is handled (by another
thread) faster than the state change is done, which could
cause an invalid state check if the streaming state is
attempted to be set before the enabling state.

Since the events from the controller may be handled by a
different thread, we should not assume that this function returns
before the event is handled.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
This commit is contained in:
Emil Gydesen 2023-08-31 15:30:31 +02:00 • committed by Carles Cufí
commit 68a4d0f6c5
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
subsys/bluetooth/audio/bap_broadcast_source.c
View file

@ -175,7 +175,7 @@ static void broadcast_source_iso_connected(struct bt_iso_chan *chan)
if (ops != NULL && ops->started != NULL) {
ops->started(stream);
} else {
LOG_WRN("No callback for connected set");
LOG_WRN("No callback for started set");
}
}
@ -884,14 +884,19 @@ int bt_bap_broadcast_source_start(struct bt_bap_broadcast_source *source, struct
sizeof(param.bcode));
}
/* Set the enabling state early in case that the BIS is connected before we can manage to
* set it afterwards
*/
broadcast_source_set_state(source, BT_BAP_EP_STATE_ENABLING);
err = bt_iso_big_create(adv, &param, &source->big);
if (err != 0) {
LOG_DBG("Failed to create BIG: %d", err);
broadcast_source_set_state(source, BT_BAP_EP_STATE_QOS_CONFIGURED);
return err;
}
broadcast_source_set_state(source, BT_BAP_EP_STATE_ENABLING);
return 0;
}