michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: lwm2m: fix potential invalid pointer dereference in reset message

Browse source 
Sometimes message is being reset from multiple locations in code.
If message has already been reset, pointer to context is invalid.

Signed-off-by: Marin Jurjević <marin.jurjevic@hotmail.com>
This commit is contained in:
Marin Jurjević 2022-03-18 13:35:36 +01:00 • committed by Carles Cufí
commit 683868f3d2
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
subsys/net/lib/lwm2m/lwm2m_engine.c
View file

@ -1333,7 +1333,9 @@ void lwm2m_reset_message(struct lwm2m_message *msg, bool release)
coap_reply_clear(msg->reply);
}
sys_slist_find_and_remove(&msg->ctx->pending_sends, &msg->node);
if (msg->ctx) {
sys_slist_find_and_remove(&msg->ctx->pending_sends, &msg->node);
}
if (release) {
(void)memset(msg, 0, sizeof(*msg));