michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Drivers: serial: Fix stm32 uart async api callback

Browse source 
Fixes the bug when driver changes offset after
the callback call. When you have the ready event
you suppose no changes in driver data after that.
Fixes #31973

Signed-off-by: Alexander Shuklin <jasuramme@gmail.com>
This commit is contained in:
Alexander Shuklin 2021-02-04 12:00:49 +03:00 • committed by Anas Nashif
commit 6831b8b15e
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
drivers/serial/uart_stm32.c
View file

@ -653,6 +653,9 @@ static inline void async_evt_rx_rdy(struct uart_stm32_data *data)
.data.rx.offset = data->dma_rx.offset
};
/* update the current pos for new data */
data->dma_rx.offset = data->dma_rx.counter;
/* send event only for new data */
if (event.data.rx.len > 0) {
async_user_callback(data, &event);
@ -750,9 +753,6 @@ static void uart_stm32_dma_rx_flush(const struct device *dev)
data->dma_rx.counter = rx_rcv_len;
async_evt_rx_rdy(data);
/* update the current pos for new data */
data->dma_rx.offset = rx_rcv_len;
}
}
}
@ -953,8 +953,6 @@ void uart_stm32_dma_rx_cb(const struct device *dma_dev, void *user_data,
async_evt_rx_rdy(data);
data->dma_rx.offset = data->dma_rx.counter;
if (data->rx_next_buffer != NULL) {
async_evt_rx_buf_release(data);