michaelh/zephyr
1
0
Fork 0
Code Releases Activity

mbox: Enforce callback registration before enabling the channel

Browse source 
Specify in the API that the callback must be registered before the
channel is enabled, fix the NRFX IPC driver to be compliant and change
the MBOX sample.

Signed-off-by: Carlo Caione <ccaione@baylibre.com>
This commit is contained in:
Carlo Caione 2021-12-03 14:53:40 +01:00 • committed by Carles Cufí
commit 67ef1df950
4 changed files with 30 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
drivers/mbox/mbox_nrfx_ipc.c
View file

@ -89,7 +89,7 @@ static int mbox_nrf_register_callback(const struct device *dev, uint32_t channel
{
struct mbox_nrf_data *data = dev->data;
if (!is_rx_channel_valid(dev, channel)) {
if (channel >= IPC_CONF_NUM) {
return -EINVAL;
}
@ -123,6 +123,10 @@ static int mbox_nrf_set_enabled(const struct device *dev, uint32_t channel, bool
return -EALREADY;
}
if (enable && (data->cb[channel] == NULL)) {
LOG_WRN("Enabling channel without a registered callback\n");
}
if (enable && data->enabled_mask == 0) {
irq_enable(DT_INST_IRQN(0));
}