michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: spi: stm32: Skip pinctrl setup for subghzspi

Browse source 
Subghzspi instances cannot have any pinctrl configs,
they are blacklisted by the dts binding. This caused an
initialization failure of the spi_ll_stm32 driver for
subghzspi instance because no "default" pinctrl was found.

This commit solves the problem by skipping the pinctrl setup
for subghzpi devices. The use_subghzpi_nss property is used
to identify a subghzspi device, as this is a required boolean
property only available in the subghzspi binding this is a
perfect indicator for such instances.

Signed-off-by: Alexander Mihajlovic <a@abxy.se>
This commit is contained in:
Alexander Mihajlovic 2022-01-05 15:22:36 +01:00 • committed by Carles Cufí
commit 673806aef1
1 changed files with 19 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

24
drivers/spi/spi_ll_stm32.c
View file

@ -838,6 +838,18 @@ static const struct spi_driver_api api_funcs = {
.release = spi_stm32_release, .release = spi_stm32_release,
}; };
static inline bool spi_stm32_is_subghzspi(const struct device *dev)
{
#if DT_HAS_COMPAT_STATUS_OKAY(st_stm32_spi_subghz)
const struct spi_stm32_config *cfg = dev->config;
return cfg->use_subghzspi_nss;
#else
ARG_UNUSED(dev);
return false;
#endif
}
static int spi_stm32_init(const struct device *dev) static int spi_stm32_init(const struct device *dev)
{ {
struct spi_stm32_data *data __attribute__((unused)) = dev->data; struct spi_stm32_data *data __attribute__((unused)) = dev->data;
@ -850,11 +862,13 @@ static int spi_stm32_init(const struct device *dev)
return -EIO; return -EIO;
} }
/* Configure dt provided device signals when available */ if (!spi_stm32_is_subghzspi(dev)) {
err = pinctrl_apply_state(cfg->pcfg, PINCTRL_STATE_DEFAULT); /* Configure dt provided device signals when available */
if (err < 0) { err = pinctrl_apply_state(cfg->pcfg, PINCTRL_STATE_DEFAULT);
LOG_ERR("SPI pinctrl setup failed (%d)", err); if (err < 0) {
return err; LOG_ERR("SPI pinctrl setup failed (%d)", err);
return err;
}
} }
#ifdef CONFIG_SPI_STM32_INTERRUPT #ifdef CONFIG_SPI_STM32_INTERRUPT