michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kernel: Explicitly ignoring memcpy return

Browse source 
memcpy always return a pointer to dest, it can be ignored. Just making
it explicitly so compilers will never raise warnings/errors to this.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
This commit is contained in:
Flavio Ceolin 2018-08-13 15:17:04 -07:00 • committed by Anas Nashif
commit 6699423a2f
6 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

8
kernel/init.c
View file

@ -181,18 +181,18 @@ void _bss_zero(void)
*/
void _data_copy(void)
{
memcpy(&__data_ram_start, &__data_rom_start,
(void)memcpy(&__data_ram_start, &__data_rom_start,
((u32_t) &__data_ram_end - (u32_t) &__data_ram_start));
#ifdef CONFIG_CCM_BASE_ADDRESS
memcpy(&__ccm_data_start, &__ccm_data_rom_start,
(void)memcpy(&__ccm_data_start, &__ccm_data_rom_start,
((u32_t) &__ccm_data_end - (u32_t) &__ccm_data_start));
#endif
#ifdef CONFIG_APP_SHARED_MEM
memcpy(&_app_smem_start, &_app_smem_rom_start,
(void)memcpy(&_app_smem_start, &_app_smem_rom_start,
((u32_t) &_app_smem_end - (u32_t) &_app_smem_start));
#endif
#ifdef CONFIG_APPLICATION_MEMORY
memcpy(&__app_data_ram_start, &__app_data_rom_start,
(void)memcpy(&__app_data_ram_start, &__app_data_rom_start,
((u32_t) &__app_data_ram_end - (u32_t) &__app_data_ram_start));
#endif
}

2
kernel/mailbox.c
View file

@ -347,7 +347,7 @@ void k_mbox_data_get(struct k_mbox_msg *rx_msg, void *buffer)
/* copy message data to buffer, then dispose of message */
if ((rx_msg->tx_data != NULL) && (rx_msg->size > 0)) {
memcpy(buffer, rx_msg->tx_data, rx_msg->size);
(void)memcpy(buffer, rx_msg->tx_data, rx_msg->size);
}
mbox_message_dispose(rx_msg);
}

2
kernel/mempool.c
View file

@ -148,7 +148,7 @@ void *k_mem_pool_malloc(struct k_mem_pool *pool, size_t size)
}
/* save the block descriptor info at the start of the actual block */
memcpy(block.data, &block.id, sizeof(struct k_mem_block_id));
(void)memcpy(block.data, &block.id, sizeof(struct k_mem_block_id));
/* return address of the user area part of the block to the caller */
return (char *)block.data + sizeof(struct k_mem_block_id);

8
kernel/msg_q.c
View file

@ -121,7 +121,7 @@ int _impl_k_msgq_put(struct k_msgq *q, void *data, s32_t timeout)
pending_thread = _unpend_first_thread(&q->wait_q);
if (pending_thread) {
/* give message to waiting thread */
memcpy(pending_thread->base.swap_data, data,
(void)memcpy(pending_thread->base.swap_data, data,
q->msg_size);
/* wake up waiting thread */
_set_thread_return_value(pending_thread, 0);
@ -130,7 +130,7 @@ int _impl_k_msgq_put(struct k_msgq *q, void *data, s32_t timeout)
return 0;
} else {
/* put message in queue */
memcpy(q->write_ptr, data, q->msg_size);
(void)memcpy(q->write_ptr, data, q->msg_size);
q->write_ptr += q->msg_size;
if (q->write_ptr == q->buffer_end) {
q->write_ptr = q->buffer_start;
@ -193,7 +193,7 @@ int _impl_k_msgq_get(struct k_msgq *q, void *data, s32_t timeout)
if (q->used_msgs > 0) {
/* take first available message from queue */
memcpy(data, q->read_ptr, q->msg_size);
(void)memcpy(data, q->read_ptr, q->msg_size);
q->read_ptr += q->msg_size;
if (q->read_ptr == q->buffer_end) {
q->read_ptr = q->buffer_start;
@ -204,7 +204,7 @@ int _impl_k_msgq_get(struct k_msgq *q, void *data, s32_t timeout)
pending_thread = _unpend_first_thread(&q->wait_q);
if (pending_thread) {
/* add thread's message to queue */
memcpy(q->write_ptr, pending_thread->base.swap_data,
(void)memcpy(q->write_ptr, pending_thread->base.swap_data,
q->msg_size);
q->write_ptr += q->msg_size;
if (q->write_ptr == q->buffer_end) {

4
kernel/poll.c
View file

@ -272,7 +272,7 @@ Z_SYSCALL_HANDLER(k_poll, events, num_events, timeout)
irq_unlock(key);
goto oops_free;
}
memcpy(events_copy, (void *)events, bounds);
(void)memcpy(events_copy, (void *)events, bounds);
irq_unlock(key);
/* Validate what's inside events_copy */
@ -303,7 +303,7 @@ Z_SYSCALL_HANDLER(k_poll, events, num_events, timeout)
}
ret = k_poll(events_copy, num_events, timeout);
memcpy((void *)events, events_copy, bounds);
(void)memcpy((void *)events, events_copy, bounds);
out_free:
k_free(events_copy);
out:

4
kernel/userspace.c
View file

@ -597,7 +597,7 @@ void *z_user_alloc_from_copy(void *src, size_t size)
goto out_err;
}
memcpy(dst, src, size);
(void)memcpy(dst, src, size);
out_err:
irq_unlock(key);
return dst;
@ -616,7 +616,7 @@ static int user_copy(void *dst, void *src, size_t size, bool to_user)
goto out_err;
}
memcpy(dst, src, size);
(void)memcpy(dst, src, size);
ret = 0;
out_err:
irq_unlock(key);