michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers/interrupt_controller: Use proper destination mode on VT-D

Browse source 
Let's always use logical Destination ID.

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
This commit is contained in:
Tomasz Bursztyka 2021-03-05 09:47:09 +01:00 • committed by Anas Nashif
commit 666318e9b7
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
drivers/interrupt_controller/intc_intel_vtd.c
View file

@ -22,6 +22,7 @@
#include <arch/x86/intel_vtd.h> #include <arch/x86/intel_vtd.h>
#include <drivers/interrupt_controller/intel_vtd.h> #include <drivers/interrupt_controller/intel_vtd.h>
#include <drivers/interrupt_controller/ioapic.h> #include <drivers/interrupt_controller/ioapic.h>
#include <drivers/interrupt_controller/loapic.h>
#include <drivers/pcie/msi.h> #include <drivers/pcie/msi.h>
#include <kernel_arch_func.h> #include <kernel_arch_func.h>
@ -339,15 +340,17 @@ static int vtd_ictl_remap(const struct device *dev,
irte.bits.vector = vector; irte.bits.vector = vector;
if (IS_ENABLED(CONFIG_X2APIC)) { if (IS_ENABLED(CONFIG_X2APIC)) {
irte.bits.dst_id = arch_curr_cpu()->id; /* Getting the logical APIC ID */
irte.bits.dst_id = x86_read_loapic(LOAPIC_LDR);
} else { } else {
irte.bits.dst_id = arch_curr_cpu()->id << 8; /* As for IOAPIC: let's mask all possible IDs */
irte.bits.dst_id = 0xFF << 8;
} }
irte.bits.trigger_mode = (flags & IOAPIC_TRIGGER_MASK) >> 15; irte.bits.trigger_mode = (flags & IOAPIC_TRIGGER_MASK) >> 15;
irte.bits.delivery_mode = (flags & IOAPIC_DELIVERY_MODE_MASK) >> 8; irte.bits.delivery_mode = (flags & IOAPIC_DELIVERY_MODE_MASK) >> 8;
irte.bits.dst_mode = 1;
irte.bits.redirection_hint = 1; irte.bits.redirection_hint = 1;
irte.bits.dst_mode = 1; /* Always logical */
irte.bits.present = 1; irte.bits.present = 1;
data->irte[irte_idx].parts.low = irte.parts.low; data->irte[irte_idx].parts.low = irte.parts.low;