michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: led: lp5562: reuse engine already linked

Browse source 
Right now "lp5562_led_blink" unconditionally find and assign a engine
that is not executing at the moment. This is an issue, if 3 "led" are
already using an engine. That is a call to "lp5562_led_blink" could
terminate with error, even if the "led" is already using an engine.
This commit fixes this issue by adding a check to see if engine is
linked and reuse it, otherwise assign a free engine.

Signed-off-by: Anuj Pathak <anuj@croxel.com>
This commit is contained in:
Anuj Pathak 2024-08-22 17:54:39 +05:30 • committed by Carles Cufí
commit 645beff897
1 changed files with 17 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

22
drivers/led/lp5562.c
View file

@ -769,15 +769,27 @@ static int lp5562_led_blink(const struct device *dev, uint32_t led,
enum lp5562_led_sources engine;
uint8_t command_index = 0U;
ret = lp5562_get_available_engine(dev, &engine);
/*
* Read current "led" source setting. This is to check
* whether the "led" is in PWM mode or using an Engine.
*/
ret = lp5562_get_led_source(dev, led, &engine);
if (ret) {
return ret;
}
ret = lp5562_set_led_source(dev, led, engine);
if (ret) {
LOG_ERR("Failed to set LED source.");
return ret;
/* Find and assign new engine only if the "led" is not using any. */
if (engine == LP5562_SOURCE_PWM) {
ret = lp5562_get_available_engine(dev, &engine);
if (ret) {
return ret;
}
ret = lp5562_set_led_source(dev, led, engine);
if (ret) {
LOG_ERR("Failed to set LED source.");
return ret;
}
}
ret = lp5562_set_engine_op_mode(dev, engine, LP5562_OP_MODE_LOAD);