michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: Verify correctness of iface_api inside L2 driver API

Browse source 
Add build time check that guarantees that iface_api struct is the
first entry inside L2 driver data. This makes sure we do not miss
a case when the ordering of the fields in the struct is changed.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2019-11-26 11:04:32 +02:00 • committed by Anas Nashif
commit 6378ac4e38
7 changed files with 35 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
include/net/can.h
View file

@ -110,6 +110,11 @@ struct net_can_api {
int (*enable)(struct device *dev, bool enable); int (*enable)(struct device *dev, bool enable);
}; };
/* Make sure that the network interface API is properly setup inside
* net_can_api struct (it is the first one).
*/
BUILD_ASSERT(offsetof(struct net_can_api, iface_api) == 0);
/** @cond INTERNAL_HIDDEN */ /** @cond INTERNAL_HIDDEN */
#define CANBUS_L2_CTX_TYPE struct net_canbus_context * #define CANBUS_L2_CTX_TYPE struct net_canbus_context *

5
include/net/dummy.h
View file

@ -33,6 +33,11 @@ struct dummy_api {
int (*send)(struct device *dev, struct net_pkt *pkt); int (*send)(struct device *dev, struct net_pkt *pkt);
}; };
/* Make sure that the network interface API is properly setup inside
* dummy API struct (it is the first one).
*/
BUILD_ASSERT(offsetof(struct dummy_api, iface_api) == 0);
#ifdef __cplusplus #ifdef __cplusplus
} }
#endif #endif

5
include/net/ethernet.h
View file

@ -265,6 +265,11 @@ struct ethernet_api {
int (*send)(struct device *dev, struct net_pkt *pkt); int (*send)(struct device *dev, struct net_pkt *pkt);
}; };
/* Make sure that the network interface API is properly setup inside
* Ethernet API struct (it is the first one).
*/
BUILD_ASSERT(offsetof(struct ethernet_api, iface_api) == 0);
/** @cond INTERNAL_HIDDEN */ /** @cond INTERNAL_HIDDEN */
struct net_eth_hdr { struct net_eth_hdr {
struct net_eth_addr dst; struct net_eth_addr dst;

5
include/net/ieee802154_radio.h
View file

@ -154,6 +154,11 @@ struct ieee802154_radio_api {
#endif /* CONFIG_NET_L2_OPENTHREAD */ #endif /* CONFIG_NET_L2_OPENTHREAD */
}; };
/* Make sure that the network interface API is properly setup inside
* IEEE 802154 radio API struct (it is the first one).
*/
BUILD_ASSERT(offsetof(struct ieee802154_radio_api, iface_api) == 0);
#define IEEE802154_AR_FLAG_SET (0x20) #define IEEE802154_AR_FLAG_SET (0x20)
/** /**

5
include/net/ppp.h
View file

@ -62,6 +62,11 @@ struct ppp_api {
#endif #endif
}; };
/* Make sure that the network interface API is properly setup inside
* PPP API struct (it is the first one).
*/
BUILD_ASSERT(offsetof(struct ppp_api, iface_api) == 0);
/** /**
* PPP protocol types. * PPP protocol types.
* See https://www.iana.org/assignments/ppp-numbers/ppp-numbers.xhtml * See https://www.iana.org/assignments/ppp-numbers/ppp-numbers.xhtml

5
include/net/socket_can.h
View file

@ -77,6 +77,11 @@ struct canbus_api {
const void *optval, socklen_t *optlen); const void *optval, socklen_t *optlen);
}; };
/* Make sure that the network interface API is properly setup inside
* CANBUS API struct (it is the first one).
*/
BUILD_ASSERT(offsetof(struct canbus_api, iface_api) == 0);
/** /**
* @} * @}
*/ */

5
include/net/wifi_mgmt.h
View file

@ -131,6 +131,11 @@ struct net_wifi_mgmt_offload {
int (*ap_disable)(struct device *dev); int (*ap_disable)(struct device *dev);
}; };
/* Make sure that the network interface API is properly setup inside
* Wifi mgmt offload API struct (it is the first one).
*/
BUILD_ASSERT(offsetof(struct net_wifi_mgmt_offload, iface_api) == 0);
#ifdef CONFIG_WIFI_OFFLOAD #ifdef CONFIG_WIFI_OFFLOAD
void wifi_mgmt_raise_connect_result_event(struct net_if *iface, int status); void wifi_mgmt_raise_connect_result_event(struct net_if *iface, int status);