michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kernel: ksched.h: Incorrect argument type in _pend_current_thread

Browse source 
In _pend_current_thread the argument key is always a unsigned
interger type and this function forces it to become a signed
interger. This is a dangerous behavior and cant be trusted to
work as expected.

Signed-off-by: Adithya Baglody <adithya.nagaraj.baglody@intel.com>
This commit is contained in:
Adithya Baglody 2018-10-16 11:48:51 +05:30 • committed by Anas Nashif
commit 6176692f4b
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
kernel/include/ksched.h
View file

@ -37,7 +37,7 @@ void _move_thread_to_end_of_prio_q(struct k_thread *thread);
void _remove_thread_from_ready_q(struct k_thread *thread); void _remove_thread_from_ready_q(struct k_thread *thread);
int _is_thread_time_slicing(struct k_thread *thread); int _is_thread_time_slicing(struct k_thread *thread);
void _unpend_thread_no_timeout(struct k_thread *thread); void _unpend_thread_no_timeout(struct k_thread *thread);
int _pend_current_thread(int key, _wait_q_t *wait_q, s32_t timeout); int _pend_current_thread(u32_t key, _wait_q_t *wait_q, s32_t timeout);
void _pend_thread(struct k_thread *thread, _wait_q_t *wait_q, s32_t timeout); void _pend_thread(struct k_thread *thread, _wait_q_t *wait_q, s32_t timeout);
void _reschedule(u32_t key); void _reschedule(u32_t key);
struct k_thread *_unpend_first_thread(_wait_q_t *wait_q); struct k_thread *_unpend_first_thread(_wait_q_t *wait_q);

2
kernel/sched.c
View file

@ -377,7 +377,7 @@ void z_thread_timeout(struct _timeout *to)
} }
#endif #endif
int _pend_current_thread(int key, _wait_q_t *wait_q, s32_t timeout) int _pend_current_thread(u32_t key, _wait_q_t *wait_q, s32_t timeout)
{ {
pend(_current, wait_q, timeout); pend(_current, wait_q, timeout);
return _Swap(key); return _Swap(key);