michaelh/zephyr
1
0
Fork 0
Code Releases Activity

shell: modules: devmem: use strtoul instead of strtol

Browse source 
All variables for address, width and value are unsigned, so use strtoul
instead of strtol. This fixes an issue when 0xffffffff is about to be
assigned to specific address, which was truncated to 0x7fffffff so far.

Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
This commit is contained in:
Marcin Niestroj 2021-07-07 18:38:32 +02:00 • committed by Anas Nashif
commit 611a1ae51a
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
subsys/shell/modules/devmem_service.c
View file

@ -71,7 +71,7 @@ static int cmd_devmem(const struct shell *sh, size_t argc, char **argv)
return -EINVAL;
}
phys_addr = strtol(argv[1], NULL, 16);
phys_addr = strtoul(argv[1], NULL, 16);
#if defined(CONFIG_MMU) || defined(CONFIG_PCIE)
device_map((mm_reg_t *)&addr, phys_addr, 0x100, K_MEM_CACHE_NONE);
@ -84,7 +84,7 @@ static int cmd_devmem(const struct shell *sh, size_t argc, char **argv)
if (argc < 3) {
width = 32;
} else {
width = strtol(argv[2], NULL, 10);
width = strtoul(argv[2], NULL, 10);
}
shell_fprintf(sh, SHELL_NORMAL, "Using data width %d\n", width);
@ -97,7 +97,7 @@ static int cmd_devmem(const struct shell *sh, size_t argc, char **argv)
* this value at the address provided
*/
value = strtol(argv[3], NULL, 16);
value = strtoul(argv[3], NULL, 16);
shell_fprintf(sh, SHELL_NORMAL, "Writing value 0x%lx\n", value);