michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: gpio: sam: fix pull reconfiguration

Browse source 
In the fine print of the manual it's stated that attempts to enable a
pull in one direction while the pull in the other direction is enabled
are ignored.  This has been confirmed.  Change logic to disable both
pulls, then enable the one that's configured, if any.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
This commit is contained in:
Peter Bigot 2019-10-30 05:35:59 -05:00 • committed by Carles Cufí
commit 5d30d5cb03
1 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

21
drivers/gpio/gpio_sam.c
View file

@ -84,24 +84,27 @@ static int gpio_sam_port_configure(struct device *dev, u32_t mask, int flags)
/* Note: Input is always enabled. */
/* Setup Pull-up resistor. */
/* Setup selected Pull resistor.
*
* A pull cannot be enabled if the opposite pull is enabled.
* Clear both pulls, then enable the one we need.
*/
pio->PIO_PUDR = mask;
#if defined(CONFIG_SOC_SERIES_SAM4S) || defined(CONFIG_SOC_SERIES_SAME70)
pio->PIO_PPDDR = mask;
#endif
if (flags & GPIO_PULL_UP) {
/* Enable pull-up. */
pio->PIO_PUER = mask;
} else {
pio->PIO_PUDR = mask;
}
#if defined(CONFIG_SOC_SERIES_SAM4S) || \
defined(CONFIG_SOC_SERIES_SAME70) || \
defined(CONFIG_SOC_SERIES_SAMV71)
/* Setup Pull-down resistor. */
if (flags & GPIO_PULL_DOWN) {
} else if (flags & GPIO_PULL_DOWN) {
/* Enable pull-down. */
pio->PIO_PPDER = mask;
} else {
pio->PIO_PPDDR = mask;
}
#endif
}
#if defined(CONFIG_SOC_SERIES_SAM3X)
/* Setup debounce. */