michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: ipv6: Fix lladdr state set to a wrong value

Browse source 
The line below is wrong and useless:
	lladdr->state = ADDR_AUTOCONF;

Indeed the three possible values for the state attribute are:
ADDR_TENTATIVE, ADDR_PREFERRED or ADDR_DEPRECATED. ADDR_AUTOCONF
is one possible value for the type attribute.

Moreover uip_ds6_set_lladdr already set the type attribute to
ADDR_AUTOCONF (this done through the call to the function
uip_ds6_addr_add).

Therefore this issue has been simply fixed by removing the line.

Change-Id: I432b7bb6a6a858264bb634f2e4d253f55acbbd5b
Signed-off-by: Sebastien Griffoul <sebastien.griffoul@intel.com>
This commit is contained in:
Sebastien Griffoul 2016-05-26 11:17:56 +02:00 • committed by Jukka Rissanen
commit 57cd9939d6
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
net/ip/net_core.c
View file

@ -1009,8 +1009,6 @@ int net_set_mac(uint8_t *mac, uint8_t len)
NET_DBG("Tentative link-local IPv6 address ");
PRINT6ADDR(&lladdr->ipaddr);
PRINTF("\n");
lladdr->state = ADDR_AUTOCONF;
}
#else
memcpy(&uip_lladdr, mac, len);