From 571273b78c0f6deea94b709ff4e94b131443d1fb Mon Sep 17 00:00:00 2001 From: Jamie McCrae Date: Fri, 13 Jan 2023 13:20:04 +0000 Subject: [PATCH] mgmt: mcumgr: Change transport select to depends on This changes some of the MCUmgr transport CMake select statements to depends on, this is to align with other in-tree symbols that do not pull in whole subsystems and instead only allow selection if those subsystems are already enabled. Signed-off-by: Jamie McCrae --- subsys/mgmt/mcumgr/transport/Kconfig.bluetooth | 3 +-- subsys/mgmt/mcumgr/transport/Kconfig.shell | 3 +-- subsys/mgmt/mcumgr/transport/Kconfig.uart | 9 ++++++--- subsys/mgmt/mcumgr/transport/Kconfig.udp | 3 +-- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/subsys/mgmt/mcumgr/transport/Kconfig.bluetooth b/subsys/mgmt/mcumgr/transport/Kconfig.bluetooth index 22e25951a60..cf6c60511ec 100644 --- a/subsys/mgmt/mcumgr/transport/Kconfig.bluetooth +++ b/subsys/mgmt/mcumgr/transport/Kconfig.bluetooth @@ -11,8 +11,7 @@ menuconfig MCUMGR_TRANSPORT_BT bool "Bluetooth mcumgr SMP transport" - select BT - select BT_PERIPHERAL + depends on BT_PERIPHERAL select BT_GATT_DYNAMIC_DB help Enables handling of SMP commands received over Bluetooth. diff --git a/subsys/mgmt/mcumgr/transport/Kconfig.shell b/subsys/mgmt/mcumgr/transport/Kconfig.shell index 6346e1b746f..bb74713137f 100644 --- a/subsys/mgmt/mcumgr/transport/Kconfig.shell +++ b/subsys/mgmt/mcumgr/transport/Kconfig.shell @@ -11,8 +11,7 @@ menuconfig MCUMGR_TRANSPORT_SHELL bool "Shell mcumgr SMP transport" - select SHELL - select SHELL_BACKEND_SERIAL + depends on SHELL select BASE64 help Enables handling of SMP commands received over shell. This allows diff --git a/subsys/mgmt/mcumgr/transport/Kconfig.uart b/subsys/mgmt/mcumgr/transport/Kconfig.uart index 4c8a312ce44..1fef7bb4118 100644 --- a/subsys/mgmt/mcumgr/transport/Kconfig.uart +++ b/subsys/mgmt/mcumgr/transport/Kconfig.uart @@ -11,7 +11,7 @@ menuconfig MCUMGR_TRANSPORT_UART bool "UART mcumgr SMP transport" - select CONSOLE + depends on CONSOLE select UART_MCUMGR select BASE64 help @@ -20,7 +20,9 @@ menuconfig MCUMGR_TRANSPORT_UART commands to be received over UART without requiring an additional thread. -if UART_ASYNC_API && MCUMGR_TRANSPORT_UART +if MCUMGR_TRANSPORT_UART + +if UART_ASYNC_API menuconfig MCUMGR_TRANSPORT_UART_ASYNC bool "Use async UART API when available" @@ -52,8 +54,9 @@ endif # UART_ASYNC_API config MCUMGR_TRANSPORT_UART_MTU int "UART SMP MTU" default 256 - depends on MCUMGR_TRANSPORT_UART help Maximum size of SMP frames sent and received over UART, in bytes. This value must satisfy the following relation: MCUMGR_TRANSPORT_UART_MTU <= MCUMGR_TRANSPORT_NETBUF_SIZE + 2 + +endif # MCUMGR_TRANSPORT_UART diff --git a/subsys/mgmt/mcumgr/transport/Kconfig.udp b/subsys/mgmt/mcumgr/transport/Kconfig.udp index 020770a4bc2..7e177bb62bb 100644 --- a/subsys/mgmt/mcumgr/transport/Kconfig.udp +++ b/subsys/mgmt/mcumgr/transport/Kconfig.udp @@ -11,8 +11,7 @@ menuconfig MCUMGR_TRANSPORT_UDP bool "UDP mcumgr SMP transport" - select NETWORKING - select NET_UDP + depends on NET_UDP select NET_SOCKETS select NET_SOCKETS_POSIX_NAMES if !POSIX_API help