From 569e64557fbda7b07765b41d7b40fda9890fe711 Mon Sep 17 00:00:00 2001 From: Ulf Magnusson Date: Thu, 7 Mar 2019 05:17:14 +0100 Subject: [PATCH] kconfig: drivers: audio: Remove redundant AUDIO_DMIC deps. These files are 'source'd within an 'if AUDIO_DMIC', in drivers/audio/Kconfig. 'if FOO' is just shorthand for adding 'depends on FOO' to each item within the 'if'. Dependencies on menus work similarly. There are no "conditional includes" in Kconfig, so 'if FOO' has no special meaning around a source. Conditional includes wouldn't be possible, because an if condition could include (directly or indirectly) forward references to symbols not defined yet. Tip: When adding a symbol, check its dependencies in the menuconfig ('ninja menuconfig', then / to jump to the symbol). The menuconfig also shows how the file with the symbol got included, so if you see duplicated dependencies, it's easy to hunt down where they come from. Signed-off-by: Ulf Magnusson --- drivers/audio/Kconfig.intel_dmic | 1 - drivers/audio/Kconfig.mpxxdtyy | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/audio/Kconfig.intel_dmic b/drivers/audio/Kconfig.intel_dmic index ff2b5879540..ec48ccc920f 100644 --- a/drivers/audio/Kconfig.intel_dmic +++ b/drivers/audio/Kconfig.intel_dmic @@ -6,6 +6,5 @@ menuconfig AUDIO_INTEL_DMIC bool "Intel digital PDM microphone driver support" - depends on AUDIO_DMIC help Enable Intel digital PDM microphone driver diff --git a/drivers/audio/Kconfig.mpxxdtyy b/drivers/audio/Kconfig.mpxxdtyy index 8ebc9237466..d37b0a2b78b 100644 --- a/drivers/audio/Kconfig.mpxxdtyy +++ b/drivers/audio/Kconfig.mpxxdtyy @@ -6,7 +6,6 @@ menuconfig AUDIO_MPXXDTYY bool "ST Digital PDM microphone attached to I2S support" - depends on AUDIO_DMIC depends on I2S select HAS_STLIB help