michaelh/zephyr
1
0
Fork 0
Code Releases Activity

arch/x86_64: Non-kconfig symbols shouldn't look like kconfig

Browse source 
The lowest level of the x86_64 bit port supports the full 64 bit ABI
just fine, but Zephyr does not (yet) and builds under the x32 ABI
instead.  The xuk layer can be built with or without the -mx32 switch,
and it had a configurable in a header to tell it what it was.  At some
point during development I swept through and turned all those tunables
into kconfigs, but this one wasn't used by zephyr and so it got the
CONFIG_* rename but never had an entry added to a Kconfig file to
match it, and eventually got picked up by Ulf's unused symbol
detector.

Rename back.  It will probably become a kconfig again someday when we
need it.  Fixes #14059.

Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
This commit is contained in:
Andy Ross 2019-03-07 16:14:49 -08:00 • committed by Anas Nashif
commit 54ee5f7d89
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
arch/x86_64/core/xuk-config.h
View file

@ -19,7 +19,7 @@
#define CONFIG_MP_NUM_CPUS 2
#define CONFIG_XUK_64_BIT_ABI 1
#define XUK_64_BIT_ABI 1
#endif /* CONFIG_X86_64 */
#endif /* _XUK_CONFIG_H */

2
arch/x86_64/core/xuk.c
View file

@ -108,7 +108,7 @@ __asm__(".align 16\n"
" push %r11\n"
" mov %rsp, %r8\n"
" sub $48, %r8\n"
#ifdef CONFIG_XUK_64_BIT_ABI
#ifdef XUK_64_BIT_ABI
" movq %r8, (%rdx)\n"
#else
" movl %r8d, (%rdx)\n"