michaelh/zephyr
1
0
Fork 0
Code Releases Activity

subsys/mgmt/hawkbit: Check retval of mbedtls_md_update

Browse source 
Check the return value of mbedtls_md_update and break on error.

Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
This commit is contained in:
Yong Cong Sin 2021-08-31 17:04:05 +08:00 • committed by Christopher Friedt
commit 54490e8fe3
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
subsys/mgmt/hawkbit/hawkbit.c
View file

@ -847,11 +847,17 @@ static void response_cb(struct http_response *rsp,
} }
if (body_data != NULL) { if (body_data != NULL) {
ret = mbedtls_md_update(&hb_context.dl.hash_ctx, body_data,
body_len);
if (ret != 0) {
LOG_ERR("mbedTLS md update error: %d", ret);
hb_context.code_status = HAWKBIT_DOWNLOAD_ERROR;
break;
}
ret = flash_img_buffered_write( ret = flash_img_buffered_write(
&hb_context.flash_ctx, body_data, body_len, &hb_context.flash_ctx, body_data, body_len,
final_data == HTTP_DATA_FINAL); final_data == HTTP_DATA_FINAL);
mbedtls_md_update(&hb_context.dl.hash_ctx, body_data,
body_len);
if (ret < 0) { if (ret < 0) {
LOG_ERR("Flash write error: %d", ret); LOG_ERR("Flash write error: %d", ret);
hb_context.code_status = HAWKBIT_DOWNLOAD_ERROR; hb_context.code_status = HAWKBIT_DOWNLOAD_ERROR;