michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: fpga: replace runtime checks with buildtime asserts in iCE40

Browse source 
Replace NULL checks for the set and clear registers with BUILD_ASSERTs
in the iCE40 device instantiation.

Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
This commit is contained in:
Benedikt Schmidt 2024-11-19 08:44:35 +01:00 • committed by Henrik Brix Andersen
commit 53ae195f0d
2 changed files with 16 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

22
drivers/fpga/fpga_ice40.c
View file

@ -210,16 +210,6 @@ static int fpga_ice40_load_gpio(const struct device *dev, uint32_t *image_ptr, u
return -ENODEV;
}
if (config->set == NULL) {
LOG_ERR("%s: set register was not specified", dev->name);
return -EFAULT;
}
if (config->clear == NULL) {
LOG_ERR("%s: clear register was not specified", dev->name);
return -EFAULT;
}
/* prepare masks */
cs = BIT(config->bus.config.cs.gpio.pin);
clk = BIT(config->clk.pin);
@ -589,6 +579,18 @@ static int fpga_ice40_init(const struct device *dev)
BUILD_ASSERT(FPGA_ICE40_TRAILING_CLOCKS(inst) >= FPGA_ICE40_TRAILING_CLOCKS_MIN); \
BUILD_ASSERT(FPGA_ICE40_TRAILING_CLOCKS(inst) <= UINT8_MAX); \
BUILD_ASSERT(FPGA_ICE40_MHZ_DELAY_COUNT(inst) >= 0); \
BUILD_ASSERT(!DT_INST_PROP(inst, load_mode_bitbang) || \
DT_INST_NODE_HAS_PROP(inst, creset_gpios)); \
BUILD_ASSERT(!DT_INST_PROP(inst, load_mode_bitbang) || \
DT_INST_NODE_HAS_PROP(inst, cdone_gpios)); \
BUILD_ASSERT(!DT_INST_PROP(inst, load_mode_bitbang) || \
DT_INST_NODE_HAS_PROP(inst, clk_gpios)); \
BUILD_ASSERT(!DT_INST_PROP(inst, load_mode_bitbang) || \
DT_INST_NODE_HAS_PROP(inst, pico_gpios)); \
BUILD_ASSERT(!DT_INST_PROP(inst, load_mode_bitbang) || \
DT_INST_NODE_HAS_PROP(inst, gpios_set_reg)); \
BUILD_ASSERT(!DT_INST_PROP(inst, load_mode_bitbang) || \
DT_INST_NODE_HAS_PROP(inst, gpios_clear_reg)); \
\
FPGA_ICE40_PINCTRL_DEFINE(inst); \
static struct fpga_ice40_data fpga_ice40_data_##inst; \

8
tests/drivers/build_all/fpga/spi.dtsi
View file

@ -16,6 +16,10 @@ test_spi_fpga_ice40_gpio: ice40@0 {
load-mode-bitbang;
cdone-gpios = <&test_gpio 0 0>;
creset-gpios = <&test_gpio 0 0>;
clk-gpios = <&test_gpio 0 0>;
pico-gpios = <&test_gpio 0 0>;
gpios-set-reg = <0>;
gpios-clear-reg = <0>;
config-delay-us = <3900>;
};
@ -28,9 +32,5 @@ test_spi_fpga_ice40_spi: ice40@1 {
cdone-gpios = <&test_gpio 0 0>;
creset-gpios = <&test_gpio 0 0>;
clk-gpios = <&test_gpio 0 0>;
pico-gpios = <&test_gpio 0 0>;
gpios-set-reg = <0>;
gpios-clear-reg = <0>;
config-delay-us = <3900>;
};