From 52d21d7bf017349399263ae0dad5bead83eda036 Mon Sep 17 00:00:00 2001 From: Gerson Fernando Budke Date: Thu, 31 Oct 2024 18:00:45 +0100 Subject: [PATCH] soc: gd32: Drop PINCTRL from Kconfig.defconfig This Kconfig has wrongly been added to defconfig files. It is not the right place for it. It has never been the right place for it. Drivers that need it should select the symbol in their Kconfig entries. Drop PINCTL from Kconfig.defconfig and add proper select at Kconfig.gd32. Fixes #78619 Signed-off-by: Gerson Fernando Budke --- drivers/adc/Kconfig.gd32 | 1 + drivers/dac/Kconfig.gd32 | 1 + drivers/i2c/Kconfig.gd32 | 1 + drivers/pwm/Kconfig.gd32 | 1 + drivers/serial/Kconfig.gd32 | 1 + drivers/spi/Kconfig.gd32 | 1 + soc/gd/gd32/Kconfig.defconfig | 3 --- 7 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/adc/Kconfig.gd32 b/drivers/adc/Kconfig.gd32 index 96bd60d1e54..3123cccd6cf 100644 --- a/drivers/adc/Kconfig.gd32 +++ b/drivers/adc/Kconfig.gd32 @@ -7,5 +7,6 @@ config ADC_GD32 bool "GD32 ADC driver" default y depends on DT_HAS_GD_GD32_ADC_ENABLED + select PINCTRL help Enable GigaDevice GD32 ADC driver diff --git a/drivers/dac/Kconfig.gd32 b/drivers/dac/Kconfig.gd32 index 260ecce2849..607df9111a3 100644 --- a/drivers/dac/Kconfig.gd32 +++ b/drivers/dac/Kconfig.gd32 @@ -8,5 +8,6 @@ config DAC_GD32 bool "GD32 DAC driver" default y depends on DT_HAS_GD_GD32_DAC_ENABLED + select PINCTRL help Enable GigaDevice GD32 DAC driver diff --git a/drivers/i2c/Kconfig.gd32 b/drivers/i2c/Kconfig.gd32 index 3089647ca52..6e09116bb0e 100644 --- a/drivers/i2c/Kconfig.gd32 +++ b/drivers/i2c/Kconfig.gd32 @@ -5,5 +5,6 @@ config I2C_GD32 bool "GigaDevice GD32 I2C driver" default y depends on DT_HAS_GD_GD32_I2C_ENABLED + select PINCTRL help Enables GigaDevice GD32 I2C driver diff --git a/drivers/pwm/Kconfig.gd32 b/drivers/pwm/Kconfig.gd32 index f82c3b48878..9dc55872963 100644 --- a/drivers/pwm/Kconfig.gd32 +++ b/drivers/pwm/Kconfig.gd32 @@ -5,5 +5,6 @@ config PWM_GD32 bool "GigaDevice GD32 PWM driver" default y depends on DT_HAS_GD_GD32_PWM_ENABLED + select PINCTRL help Enable the GigaDevice GD32 PWM driver. diff --git a/drivers/serial/Kconfig.gd32 b/drivers/serial/Kconfig.gd32 index ed66a9a5c74..7d609267230 100644 --- a/drivers/serial/Kconfig.gd32 +++ b/drivers/serial/Kconfig.gd32 @@ -5,6 +5,7 @@ config USART_GD32 bool "GD32 serial driver" default y depends on DT_HAS_GD_GD32_USART_ENABLED + select PINCTRL select SERIAL_HAS_DRIVER select SERIAL_SUPPORT_INTERRUPT select USE_GD32_USART diff --git a/drivers/spi/Kconfig.gd32 b/drivers/spi/Kconfig.gd32 index 6c167c00441..a6e029368b1 100644 --- a/drivers/spi/Kconfig.gd32 +++ b/drivers/spi/Kconfig.gd32 @@ -5,6 +5,7 @@ config SPI_GD32 bool "Gigadevice GD32 SPI driver" default y depends on DT_HAS_GD_GD32_SPI_ENABLED + select PINCTRL help Enables Gigadevice GD32 SPI driver. diff --git a/soc/gd/gd32/Kconfig.defconfig b/soc/gd/gd32/Kconfig.defconfig index 345f14c0629..9847bb415bd 100644 --- a/soc/gd/gd32/Kconfig.defconfig +++ b/soc/gd/gd32/Kconfig.defconfig @@ -5,9 +5,6 @@ if SOC_FAMILY_GD_GD32 rsource "*/Kconfig.defconfig.series" -config PINCTRL - default y - config RESET default y