michaelh/zephyr
1
0
Fork 0
Code Releases Activity

soc: nordic: nrf54h: gpd: fix compile warning when CONFIG_DEBUG=y

Browse source 
Usage of K_SPINLOCK with CONFIG_DEBUG=y seems to trigger a compiler
warning about request not always being initialized. Fallback to
k_spin_lock/unlock calls to fix this issue.

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
This commit is contained in:
Gerard Marull-Paretas 2024-11-05 12:53:36 +01:00 • committed by Henrik Brix Andersen
commit 5249619f6a
1 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
soc/nordic/nrf54h/gpd/gpd.c
View file

@ -66,16 +66,19 @@ static int nrf_gpd_sync(struct gpd_onoff_manager *gpd_mgr)
{ {
int64_t start; int64_t start;
nrfs_err_t err; nrfs_err_t err;
k_spinlock_key_t key;
gdpwr_request_type_t request; gdpwr_request_type_t request;
K_SPINLOCK(&gpd_mgr->mgr.lock) { key = k_spin_lock(&gpd_mgr->mgr.lock);
if (gpd_mgr->mgr.refs == 0) {
request = GDPWR_POWER_REQUEST_CLEAR; if (gpd_mgr->mgr.refs == 0) {
} else { request = GDPWR_POWER_REQUEST_CLEAR;
request = GDPWR_POWER_REQUEST_SET; } else {
} request = GDPWR_POWER_REQUEST_SET;
} }
k_spin_unlock(&gpd_mgr->mgr.lock, key);
atomic_clear_bit(&gpd_service_status, GPD_SERVICE_REQ_ERR); atomic_clear_bit(&gpd_service_status, GPD_SERVICE_REQ_ERR);
atomic_clear_bit(&gpd_service_status, GPD_SERVICE_REQ_OK); atomic_clear_bit(&gpd_service_status, GPD_SERVICE_REQ_OK);