michaelh/zephyr
1
0
Fork 0
Code Releases Activity

arch: arm: aarch32: userspace: fix syscall ID validation

Browse source 
We need an unsigned comparison when evaluating whether
the supplied syscall ID is lower than the syscall ID limit.

Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
This commit is contained in:
Ioannis Glaropoulos 2020-03-06 16:06:08 +01:00 • committed by Johan Hedberg
commit 502b67ceba
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
arch/arm/core/aarch32/swap_helper.S
View file

@ -508,7 +508,10 @@ _do_syscall:
ldr ip, =K_SYSCALL_LIMIT ldr ip, =K_SYSCALL_LIMIT
cmp r6, ip cmp r6, ip
#endif #endif
blt valid_syscall_id /* The supplied syscall_id must be lower than the limit
* (Requires unsigned integer comparison)
*/
blo valid_syscall_id
/* bad syscall id. Set arg1 to bad id and set call_id to SYSCALL_BAD */ /* bad syscall id. Set arg1 to bad id and set call_id to SYSCALL_BAD */
str r6, [r0] str r6, [r0]