michaelh/zephyr
1
0
Fork 0
Code Releases Activity

ipc_service: static_vrings: Set WQ priority back to PRIO_PREEMPT

Browse source 
This reverts commit 7f51907fda.

The problem with setting the priority at the highest priority possible
is that when the IPC is under high traffic, the WQ could starve the
scheduler.

Move back to a more sane preemptive priority as default value.

Signed-off-by: Carlo Caione <ccaione@baylibre.com>
This commit is contained in:
Carlo Caione 2022-06-01 16:02:49 +02:00 • committed by Carles Cufí
commit 4ef13f7ecd
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
dts/bindings/ipc/zephyr,ipc-openamp-static-vrings.yaml
View file

@ -42,7 +42,7 @@ properties:
or for K_PRIO_PREEMPT(2)
priority = <2 PRIO_PREEMPT>;
When this property is missing a default priority of <0 PRIO_COOP> is
When this property is missing a default priority of <0 PRIO_PREEMPT> is
assumed.
zephyr,buffer-size:

2
subsys/ipc/ipc_service/backends/ipc_rpmsg_static_vrings.c
View file

@ -623,7 +623,7 @@ static int backend_init(const struct device *instance)
(0)), \
.wq_prio_type = COND_CODE_1(DT_INST_NODE_HAS_PROP(i, zephyr_priority), \
(DT_INST_PROP_BY_IDX(i, zephyr_priority, 1)), \
(PRIO_COOP)), \
(PRIO_PREEMPT)), \
.buffer_size = DT_INST_PROP_OR(i, zephyr_buffer_size, \
RPMSG_BUFFER_SIZE), \
.id = i, \