michaelh/zephyr
1
0
Fork 0
Code Releases Activity

cmake: Make enable_language() clear about what it is actually doing

Browse source 
That call to enable_languages() is passed C CXX ASM which misleads the
reader into thinking that the three languages are enabled in that call but
at that point only ASM is actually because C and CXX were already
implicitly enabled by the call to project() above. The suggested change
removes the misleading C CXX arguments but we could as well make it clear
in the project() call by passing LANGUAGES C CXX.

Signed-off-by: Nicolas Lebedenco <nicolas@lebedenco.net>
This commit is contained in:
Nicolas Lebedenco 2024-03-28 23:37:01 -04:00 • committed by Fabio Baltieri
commit 4df926b02d
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cmake/modules/kernel.cmake
View file

@ -131,7 +131,7 @@ project(Zephyr-Kernel VERSION ${PROJECT_VERSION})
# because clang from OneApi can't recognize them as asm files on
# windows now.
list(APPEND CMAKE_ASM_SOURCE_FILE_EXTENSIONS "S")
enable_language(C CXX ASM)
enable_language(ASM)
# The setup / configuration of the toolchain itself and the configuration of
# supported compilation flags are now split, as this allows to use the toolchain