michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: hwinfo: litex: fix device ID calculation

Browse source 
The `end` variable should be calculated based on the device's register
size, not the address. Probably never caught before as user typically
provides a buffer of reasonable size...

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
This commit is contained in:
Benjamin Cabé 2025-06-14 21:45:29 +02:00 • committed by Benjamin Cabé
commit 4d4b3a4efe
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/hwinfo/hwinfo_litex.c
View file

@ -15,7 +15,7 @@
ssize_t z_impl_hwinfo_get_device_id(uint8_t *buffer, size_t length)
{
uint32_t addr = DT_INST_REG_ADDR(0);
ssize_t end = MIN(length, DT_INST_REG_ADDR(0) / 4 *
ssize_t end = MIN(length, DT_INST_REG_SIZE(0) / 4 *
CONFIG_LITEX_CSR_DATA_WIDTH / 8);
for (int i = 0; i < end; i++) {
#if CONFIG_LITEX_CSR_DATA_WIDTH == 8