michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: modem: gsm: Add misc fixes like line ending char set

Browse source 
Misc fixes / enhancements to the GSM driver:
* set the \r as a line ending character
* make gsm_init() static as there is no need to expose it
* print the gsm context pointer at init
* set buffer allocation timeout to modem context so that it is
  not infinite

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2020-02-07 10:39:43 +02:00
commit 49724e25a0
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
drivers/modem/gsm_ppp.c
View file

@ -25,6 +25,7 @@ LOG_MODULE_REGISTER(modem_gsm, CONFIG_MODEM_LOG_LEVEL);
#define GSM_RX_STACK_SIZE 1024 #define GSM_RX_STACK_SIZE 1024
#define GSM_RECV_MAX_BUF 30 #define GSM_RECV_MAX_BUF 30
#define GSM_RECV_BUF_SIZE 128 #define GSM_RECV_BUF_SIZE 128
#define GSM_BUF_ALLOC_TIMEOUT K_SECONDS(1)
static struct gsm_modem { static struct gsm_modem {
struct modem_context context; struct modem_context context;
@ -248,12 +249,12 @@ static void gsm_configure(struct k_work *work)
k_sem_give(&gsm->ppp_send_sem); k_sem_give(&gsm->ppp_send_sem);
} }
int gsm_init(struct device *device) static int gsm_init(struct device *device)
{ {
struct gsm_modem *gsm = device->driver_data; struct gsm_modem *gsm = device->driver_data;
int r; int r;
LOG_DBG("Generic GSM modem"); LOG_DBG("Generic GSM modem (%p)", gsm);
k_sem_init(&gsm->ppp_send_sem, 0, 1); k_sem_init(&gsm->ppp_send_sem, 0, 1);
@ -264,6 +265,8 @@ int gsm_init(struct device *device)
gsm->cmd_handler_data.match_buf = &gsm->cmd_match_buf[0]; gsm->cmd_handler_data.match_buf = &gsm->cmd_match_buf[0];
gsm->cmd_handler_data.match_buf_len = sizeof(gsm->cmd_match_buf); gsm->cmd_handler_data.match_buf_len = sizeof(gsm->cmd_match_buf);
gsm->cmd_handler_data.buf_pool = &gsm_recv_pool; gsm->cmd_handler_data.buf_pool = &gsm_recv_pool;
gsm->cmd_handler_data.alloc_timeout = GSM_BUF_ALLOC_TIMEOUT;
gsm->cmd_handler_data.eol = "\r";
k_sem_init(&gsm->sem_response, 0, 1); k_sem_init(&gsm->sem_response, 0, 1);