michaelh/zephyr
1
0
Fork 0
Code Releases Activity

pm: cleanup pm control callback implementations

Browse source 
- Return -ENOTSUP if the requested state is not supported
- Remove redundant "noop style" functions.
- Use switch everywhere to handle requested state (not necessary in all
  drivers, but better take off with consistency in place after current
  changes).

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
This commit is contained in:
Gerard Marull-Paretas 2021-07-05 10:35:15 +02:00 • committed by Anas Nashif
commit 495672ab62
33 changed files with 263 additions and 334 deletions
Download patch file Download diff file Expand all files Collapse all files

19
drivers/serial/uart_npcx.c
View file

@ -438,11 +438,12 @@ static inline bool uart_npcx_device_is_transmitting(const struct device *dev)
return 0;
}
static inline int uart_npcx_set_power_state(const struct device *dev,
enum pm_device_state next_state)
static inline int uart_npcx_pm_control(const struct device *dev,
enum pm_device_state state)
{
/* If next device power state is LOW or SUSPEND power state */
if (next_state == PM_DEVICE_STATE_SUSPENDED) {
/* If next device power state is SUSPEND power state */
switch (state) {
case PM_DEVICE_STATE_SUSPENDED:
/*
* If uart device is busy with transmitting, the driver will
* stay in while loop and wait for the transaction is completed.
@ -450,17 +451,13 @@ static inline int uart_npcx_set_power_state(const struct device *dev,
while (uart_npcx_device_is_transmitting(dev)) {
continue;
}
break;
default:
return -ENOTSUP;
}
return 0;
}
/* Implements the device power management control functionality */
static int uart_npcx_pm_control(const struct device *dev,
enum pm_device_state state)
{
return uart_npcx_set_power_state(dev, state);
}
#endif /* CONFIG_PM_DEVICE */
#ifdef CONFIG_UART_INTERRUPT_DRIVEN