michaelh/zephyr
1
0
Fork 0
Code Releases Activity

pm: cleanup pm control callback implementations

Browse source 
- Return -ENOTSUP if the requested state is not supported
- Remove redundant "noop style" functions.
- Use switch everywhere to handle requested state (not necessary in all
  drivers, but better take off with consistency in place after current
  changes).

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
This commit is contained in:
Gerard Marull-Paretas 2021-07-05 10:35:15 +02:00 • committed by Anas Nashif
commit 495672ab62
33 changed files with 263 additions and 334 deletions
Download patch file Download diff file Expand all files Collapse all files

18
drivers/sensor/bme280/bme280.c
View file

@ -414,21 +414,25 @@ int bme280_pm_ctrl(const struct device *dev, enum pm_device_state state)
{
int ret = 0;
/* Switching from OFF to any */
if (state != PM_DEVICE_STATE_OFF) {
switch (state) {
case PM_DEVICE_STATE_ACTIVE:
/* Re-initialize the chip */
ret = bme280_chip_init(dev);
}
/* Switching to OFF from any */
else if (state == PM_DEVICE_STATE_OFF) {
break;
case PM_DEVICE_STATE_SUSPENDED:
__fallthrough;
case PM_DEVICE_STATE_OFF:
/* Put the chip into sleep mode */
ret = bme280_reg_write(dev,
BME280_REG_CTRL_MEAS,
BME280_CTRL_MEAS_OFF_VAL);
if (ret < 0)
if (ret < 0) {
LOG_DBG("CTRL_MEAS write failed: %d", ret);
}
break;
default:
return -ENOTSUP;
}
return ret;