michaelh/zephyr
1
0
Fork 0
Code Releases Activity

pm: cleanup pm control callback implementations

Browse source 
- Return -ENOTSUP if the requested state is not supported
- Remove redundant "noop style" functions.
- Use switch everywhere to handle requested state (not necessary in all
  drivers, but better take off with consistency in place after current
  changes).

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
This commit is contained in:
Gerard Marull-Paretas 2021-07-05 10:35:15 +02:00 • committed by Anas Nashif
commit 495672ab62
33 changed files with 263 additions and 334 deletions
Download patch file Download diff file Expand all files Collapse all files

10
drivers/ethernet/eth_mcux.c
View file

@ -197,7 +197,8 @@ static int eth_mcux_device_pm_control(const struct device *dev,
goto out;
}
if (state == PM_DEVICE_STATE_SUSPENDED) {
switch (state) {
case PM_DEVICE_STATE_SUSPENDED:
LOG_DBG("Suspending");
ret = net_if_suspend(eth_ctx->iface);
@ -212,13 +213,18 @@ static int eth_mcux_device_pm_control(const struct device *dev,
ENET_Deinit(eth_ctx->base);
clock_control_off(eth_ctx->clock_dev,
(clock_control_subsys_t)eth_ctx->clock);
} else if (state == PM_DEVICE_STATE_ACTIVE) {
break;
case PM_DEVICE_STATE_ACTIVE:
LOG_DBG("Resuming");
clock_control_on(eth_ctx->clock_dev,
(clock_control_subsys_t)eth_ctx->clock);
eth_mcux_init(dev);
net_if_resume(eth_ctx->iface);
break;
default:
ret = -ENOTSUP;
break;
}
out: