michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: eth: enc28j60: Fix read error when ERDPT < ERXRDPT

Browse source 
After read first packet and if ERDPT < ERXRDPT,cause read Rx FIFO error.
The fix is to set ERDPT properly before reading next packet.

Fixed #9537

Signed-off-by: Frank Li <lgl88911@163.com>
This commit is contained in:
Frank Li 2018-08-24 22:55:19 +08:00 • committed by Anas Nashif
commit 4934323931
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
drivers/ethernet/eth_enc28j60.c
View file

@ -520,6 +520,15 @@ static int eth_enc28j60_rx(struct device *dev)
u8_t info[RSV_SIZE]; u8_t info[RSV_SIZE];
struct net_pkt *pkt; struct net_pkt *pkt;
u16_t next_packet; u16_t next_packet;
u8_t rdptl = 0;
u8_t rdpth = 0;
/* remove read fifo address to packet header address */
eth_enc28j60_set_bank(dev, ENC28J60_REG_ERXRDPTL);
eth_enc28j60_read_reg(dev, ENC28J60_REG_ERXRDPTL, &rdptl);
eth_enc28j60_read_reg(dev, ENC28J60_REG_ERXRDPTH, &rdpth);
eth_enc28j60_write_reg(dev, ENC28J60_REG_ERDPTL, rdptl);
eth_enc28j60_write_reg(dev, ENC28J60_REG_ERDPTH, rdpth);
/* Read address for next packet */ /* Read address for next packet */
eth_enc28j60_read_mem(dev, info, 2); eth_enc28j60_read_mem(dev, info, 2);
@ -527,12 +536,12 @@ static int eth_enc28j60_rx(struct device *dev)
/* Errata 14. Even values in ERXRDPT /* Errata 14. Even values in ERXRDPT
* may corrupt receive buffer. * may corrupt receive buffer.
*/ No need adjust next packet
if (next_packet == 0) { if (next_packet == 0) {
next_packet = ENC28J60_RXEND; next_packet = ENC28J60_RXEND;
} else if (!(next_packet & 0x01)) { } else if (!(next_packet & 0x01)) {
next_packet--; next_packet--;
} }*/
/* Read reception status vector */ /* Read reception status vector */
eth_enc28j60_read_mem(dev, info, 4); eth_enc28j60_read_mem(dev, info, 4);