michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: nsos_sockets: Fix incorrect return return on ECONNREFUSED

Browse source 
`nsos_connect_blocking()` is not returning the error as expected. It is
expected to return a negative `NSI_ERRNO_MID_...` value, but it is
returning a positive errno value. `nsos_connect_blocking()` should map
the errno value to a negative `NSI_ERRNO_MID_...`, which `nsos_connect()`
maps back to a -1 return with errno=`ECONNREFUSED`.

the current sequence of events:
- `ECONNREFUSED` occurs during connection
- `nsos_connect_blocking()` returns positive `ECONNREFUSED`
- `nsos_connect()` returns positive `ECONNREFUSED`
- `zsock_connect()` returns positive `ECONNREFUSED`

the expected sequence of events:
- `ECONNREFUSED` occurs during connection
- `nsos_connect_blocking()` returns negative `NSI_ERRNO_MID_ECONNREFUSED`
- `nsos_connect()` returns -1, errno=`ECONNREFUSED`
- `zsock_connect()` returns -1, errno=`ECONNREFUSED`

Signed-off-by: Noah Olson <noah@wavelynx.com>
This commit is contained in:
Noah Olson 2025-04-04 11:03:16 -06:00 • committed by Benjamin Cabé
commit 4925e22a67
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/nsos_sockets.c
View file

@ -677,7 +677,7 @@ static int nsos_connect_blocking(struct nsos_socket *sock,
goto clear_nonblock; goto clear_nonblock;
} }
ret = so_err; ret = -nsi_errno_to_mid(so_err);
} }
clear_nonblock: clear_nonblock: