From 4900aecc8eac69228baf75fa5fa7d045131df91f Mon Sep 17 00:00:00 2001 From: Andrew Boie Date: Fri, 26 Feb 2016 21:41:14 -0800 Subject: [PATCH] gen_idt: correctly warn on duplicate IRQ connections Now if you try to call IRQ_CONNECT() multiple times on the same IRQ line it will correcly fail the build, as intended. Change-Id: Ia629ae3dd009bd3a2e1dbd9797dc2b723b02d234 Signed-off-by: Andrew Boie --- scripts/gen_idt/gen_idt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/gen_idt/gen_idt.c b/scripts/gen_idt/gen_idt.c index 8b6c51ea969..8edc8442293 100644 --- a/scripts/gen_idt/gen_idt.c +++ b/scripts/gen_idt/gen_idt.c @@ -391,12 +391,13 @@ static void validate_irq(void) show_entry(&supplied_entry[i]); clean_exit(-1); } - num_irqs[i]++; + num_irqs[supplied_entry[i].irq]++; } for (i = 0; i < num_irq_lines; i++) { if (num_irqs[i] > 1) { - fprintf(stderr, "Multiple requests for IRQ %d detected.\n", i); + fprintf(stderr, "Multiple requests (%d) for IRQ %d detected.\n", + num_irqs[i], i); clean_exit(-1); } }